Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Node 16 and NPM 8 #413

Merged
merged 4 commits into from
Nov 15, 2021
Merged

Node 16 and NPM 8 #413

merged 4 commits into from
Nov 15, 2021

Conversation

zackkrida
Copy link
Member

@zackkrida zackkrida commented Nov 12, 2021 •
edited
Loading

Previously, only production issues were keeping us on Node 14 and npm 6. This PR upgrades both and updates the local configuration for volta in the engines key of the package.json file.

This also builds a new package-lock.json with the updated deps.

@zackkrida zackkrida requested a review from a team as a code owner November 12, 2021 23:47
@zackkrida zackkrida added 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Nov 12, 2021
@zackkrida zackkrida changed the title Node 16 and NPM 7 Node 16 and NPM 8 Nov 13, 2021
dhruvkb
dhruvkb reviewed Nov 13, 2021
View reviewed changes
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to upgrade to the new LTS. I have a few non-blocking questions.

package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
sarayourfriend
sarayourfriend approved these changes Nov 14, 2021
View reviewed changes
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

dhruvkb
dhruvkb approved these changes Nov 14, 2021
View reviewed changes
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zackkrida zackkrida merged commit 27ca963 into main Nov 15, 2021
@zackkrida zackkrida deleted the update-versions branch November 15, 2021 00:12
rbadillap added a commit that referenced this pull request Nov 17, 2021
@rbadillap
Merge branch 'main' into ci/pipelines
53c0d26 
* main:
  Create the `InputField` and `SearchBar` components (#380)
  Add VPopover component (#397)
  Search and media store refactoring (#398)
  Node 16 and NPM 8 (#413)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dhruvkb dhruvkb dhruvkb approved these changes

@sarayourfriend sarayourfriend sarayourfriend approved these changes

@obulat obulat Awaiting requested review from obulat obulat is a code owner automatically assigned from WordPress/openverse-frontend

Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zackkrida @dhruvkb @sarayourfriend