Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downstream updates tracker for v1.0 #44

Open
4 of 10 tasks
gdalle opened this issue Apr 18, 2024 · 9 comments
Open
4 of 10 tasks

Downstream updates tracker for v1.0 #44

gdalle opened this issue Apr 18, 2024 · 9 comments

Comments

@gdalle
Copy link
Collaborator

gdalle commented Apr 18, 2024

Which dependents must we upgrade to use ADTypes v1.0?
Listed by topological order below:

I only tick the ones for which ADTypes v0.2 is no longer in the compat bound (see my comment below)

@gdalle gdalle changed the title Downstream updates tracker Downstream updates tracker for v1.0 Apr 18, 2024
@gdalle
Copy link
Collaborator Author

gdalle commented Apr 22, 2024

Is it Christmas already?

@ChrisRackauckas
Copy link
Member

No, it's a Monday. That the list that needs work to update 😅

@gdalle
Copy link
Collaborator Author

gdalle commented Apr 22, 2024

For most of those, the huge breaking change will be bumping Julia compat up to 1.10. If that is accepted, the rest is a bunch of renamings that I can try to contribute little by little

@gdalle
Copy link
Collaborator Author

gdalle commented Apr 22, 2024

Since I'm not a member of SciML, I can only create new PRs, not update those from CompatHelper though

@ChrisRackauckas
Copy link
Member

Most should already be bumped to v1.10.

@gdalle
Copy link
Collaborator Author

gdalle commented May 15, 2024

I'm trying to do one of the harder upgrades with SciML/NonlinearSolve.jl#426

Can someone make me a member of the NonlinearSolve repo, so that CI runs automatically on my commits? It's rather tedious to wait for maintainer approval.
If you want I can also join the SciML organization if it makes things easier.

@avik-pal @Vaibhavdixit02 @ChrisRackauckas

@gdalle
Copy link
Collaborator Author

gdalle commented May 15, 2024

The CompatHelper PRs that were merged don't force ADTypes v1, since they still allow v0.2.
As a result, most of them don't change anything, and ADTypes v0.2 is still the version picked by CI.

I think the right approach is to force ADTypes v1, so that we can see whether it breaks stuff or not. That's what I did in SparseDiffTools and NonlinearSolve.

However, a first step is to allow ADTypes non-exclusively everywhere so that downstream tests may run

@ChrisRackauckas
Copy link
Member

Most cases have very small usage of ADTypes. NonlinearSolve, SparseDiffTools, and BoundaryValueDiffEq are the three that require a deeper dive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants