Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for ADTypes to 1, (keep existing compat) #738

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the ADTypes package from 0.2.5 to 0.2.5, 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@github-actions github-actions bot force-pushed the compathelper/new_version/2024-04-20-00-20-00-212-00675501349 branch from f28600e to 9d9b09c Compare April 20, 2024 00:20
@torfjelde
Copy link

Hey! Is there anyting holding this PR up? It's holding up testing wtih ADTypes.jjl on in a few downstream packages 😬

@Vaibhavdixit02 Vaibhavdixit02 merged commit ca6af8f into master Apr 26, 2024
40 of 43 checks passed
@Vaibhavdixit02 Vaibhavdixit02 deleted the compathelper/new_version/2024-04-20-00-20-00-212-00675501349 branch April 26, 2024 13:41
@torfjelde
Copy link

Lovely; thank you @Vaibhavdixit02 ! Is it also possible make a release?

@Vaibhavdixit02
Copy link
Member

No problem @torfjelde! I am looking into making a release, the CI failed to resolve versions just a few minutes back so there might be a bit of delay to get other packages to do the releases as well

@torfjelde
Copy link

Gotcha 👍 Thank you for looking into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants