Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for ADTypes to 1, (keep existing compat) #140

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the ADTypes package from 0.2.6 to 0.2.6, 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.99%. Comparing base (eefb1ee) to head (8296464).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #140       +/-   ##
===========================================
- Coverage   90.58%   57.99%   -32.60%     
===========================================
  Files          23       23               
  Lines        1296     1295        -1     
===========================================
- Hits         1174      751      -423     
- Misses        122      544      +422     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Vaibhavdixit02
Copy link
Member

@avik-pal
Copy link
Member

Is this not breaking for NonlinearSolve? I thought SciML/NonlinearSolve.jl#415 needs to be handled first

@Vaibhavdixit02
Copy link
Member

No I think it just needs SciML/NonlinearSolve.jl#412 for now

@avik-pal avik-pal merged commit 32d2f42 into main Apr 28, 2024
4 of 5 checks passed
@avik-pal avik-pal deleted the compathelper/new_version/2024-04-19-22-04-48-101-01745084332 branch April 28, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants