Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADTypes 1.0 compat #674

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Add ADTypes 1.0 compat #674

merged 2 commits into from
Apr 19, 2024

Conversation

gdalle
Copy link
Contributor

@gdalle gdalle commented Apr 18, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

ADTypes is about to release a breaking v1.0, so the task of updating downstream repos begins.
This is a test PR to see if there is anything to change here. From what I can tell, the only use of ADTypes in SciMLBase is through AbstractADType, which is still available, so we should be good.

However note that this PR is not yet testing with ADTypes v1.0, so we won't know for sure what happens. In particular, restricting ADTypes v1.0 to Julia v1.10 and above (as we decided in SciML/ADTypes.jl#40 (comment)) is probably very breaking throughout the ecosystem.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.86%. Comparing base (0ec4159) to head (4984f1c).
Report is 3 commits behind head on master.

❗ Current head 4984f1c differs from pull request most recent head 30e985f. Consider uploading reports for the commit 30e985f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #674       +/-   ##
==========================================
- Coverage   40.84%   4.86%   -35.99%     
==========================================
  Files          55      55               
  Lines        4490    4443       -47     
==========================================
- Hits         1834     216     -1618     
- Misses       2656    4227     +1571     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle
Copy link
Contributor Author

gdalle commented Apr 19, 2024

@ChrisRackauckas thoughts on how to proceed here? I don't think we can really prepare draft PRs everywhere until ADTypes v1.0 is registered. We'd need to install ADTypes from the repo every single time, as well as all other dependencies (for instance SciMLBase), which means a huge chain of interlinked PR branches

@ChrisRackauckas
Copy link
Member

I think it's fine to merge since this is just the interface, and thus it won't actually be used until the downstream users (currently Optimization.jl and NonlinearSolve.jl) allow it. This then isolates the problem to the downstream places where it's actually used, which should be fine.

@gdalle
Copy link
Contributor Author

gdalle commented Apr 19, 2024

I guess this deserves a minor version bump?

@gdalle gdalle marked this pull request as ready for review April 19, 2024 10:12
@ChrisRackauckas ChrisRackauckas merged commit ab38d18 into SciML:master Apr 19, 2024
@gdalle gdalle deleted the adtypes_v1 branch April 19, 2024 14:40
@gdalle
Copy link
Contributor Author

gdalle commented Apr 21, 2024

Hi! Now that SciML/ADTypes.jl#46 is done, if ADTypes v1 doesn't break CI for SciMLBase, would it be possible to release v2.34?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants