-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Current state not compatible with ADTypes v1 despite compat bounds #44
Comments
Yeah https://github.com/SciML/OptimizationBase.jl/pull/31/files#diff-72ed386c2a0cd1d23c0968297e70023ed98c22490d146dd89fc91f48369bad4dR28 I had noticed that and was now testing with only v1. Are you suggesting a release with this independent of #31? |
I'm saying that at the moment, this package is making promises that it does not uphold (ADTypes v1 support). DI integration might take longer, but this seems easier to fix in the short run? |
I would do it myself but there are things that depend on the fields of the (not so) regretted |
Nice! |
The PR #37 was merged hastily without removing the ADTypes v0.2 compat bound, and so ADTypes v0.2 is the one used for tests.
If you removed it, you would see that ADTypes v1 is not actually supported: for instance,
AutoModelingToolkit
no longer exists (it is nowAutoSymbolics
).@Vaibhavdixit02 perhaps this can be fixed before #31 lands?
The text was updated successfully, but these errors were encountered: