Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMG-Py v2.4.1 release #1664

Merged
merged 71 commits into from
Jul 23, 2019
Merged

RMG-Py v2.4.1 release #1664

merged 71 commits into from
Jul 23, 2019

Commits on Jun 14, 2019

  1. Increase RDKit version requirement and reformat environment files

    Require newer version of RDKit and add rdkit channel
    Alphabetize dependencies
    Remove libgcc and libgfortran (they are included implicitly)
    Remove scoop
    mliu49 committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    a0eb180 View commit details
    Browse the repository at this point in the history
  2. Update Kekule SMILES tests following RDKit changes

    RDKit now generates different SMILES strings for some molecules
    mliu49 committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    1be7060 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    db32e8e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    66eae5d View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2019

  1. Merge pull request #1623 from ReactionMechanismGenerator/update_env

    Update environment files, including RDKit and Cantera versions
    Colin Grambow authored Jun 15, 2019
    Configuration menu
    Copy the full SHA
    12c16bf View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2019

  1. Configuration menu
    Copy the full SHA
    5448290 View commit details
    Browse the repository at this point in the history
  2. Implement ZPE scaling factor

    The 1.014 factor represents the relationship between the harmonic
    frequencies scaling factor and the zero point energy scaling factor,
    see https://pubs.acs.org/doi/10.1021/ct100326h Section 3.1.3.
    alongd committed Jun 16, 2019
    Configuration menu
    Copy the full SHA
    ce8707a View commit details
    Browse the repository at this point in the history
  3. Corrected the energy (e_elect, zpe, and E0) terminology in Arkane

    Previously we used E0 for the electronic energy, and E0_withZPE for the
    corrected energy.
    The updated terminology is E0 = e_electronic + ZPE
    (E0 includes the ZPE)
    alongd committed Jun 16, 2019
    Configuration menu
    Copy the full SHA
    2c9d0c8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bc242dc View commit details
    Browse the repository at this point in the history
  5. Updated the frequency scale factor assignemt

    - Corrected scaling factors which were for ZPE instead of freq
    - Organized the references
    - Removed commented out levels
    - Added some more levels (one of which calculated by Duminda, as noted)
    alongd committed Jun 16, 2019
    Configuration menu
    Copy the full SHA
    20b0d3e View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2019

  1. Merge pull request #1619 from ReactionMechanismGenerator/scaling_zpe

    Scaling zpe
    Colin Grambow authored Jun 17, 2019
    Configuration menu
    Copy the full SHA
    d9205b5 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1628 from ReactionMechanismGenerator/v2.4.0

    v2.4.0 release changes
    mliu49 authored Jun 17, 2019
    Configuration menu
    Copy the full SHA
    0f123d8 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1631 from ReactionMechanismGenerator/stable

    Merge stable branch into master
    mliu49 authored Jun 17, 2019
    Configuration menu
    Copy the full SHA
    2adfbb5 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2019

  1. add rms yaml generation

    mjohnson541 committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    ef5dd72 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a291476 View commit details
    Browse the repository at this point in the history
  3. Add yaml to project requirements

    amarkpayne authored and mjohnson541 committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    256832a View commit details
    Browse the repository at this point in the history
  4. Merge pull request #1629 from ReactionMechanismGenerator/rmsyaml

    Reaction Mechanism Simulator YAML File Generation
    mjohnson541 authored Jun 24, 2019
    Configuration menu
    Copy the full SHA
    93fac25 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2019

  1. Get NASA.as_dict to ignore unset variables

    Previously, NASA.as_dict would throw an error if attributes like
    Tmin, Tmax, E0 were unset. These variables, however, are optional,
    so Arkane should not crash if they are unset.
    
    This commit fixes the as_dict method to not throw an error
    for optional attributes
    goldmanm committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    4c6c95e View commit details
    Browse the repository at this point in the history
  2. Add tests to load species from NASA polynomials

    This commit adds two test methods for NASA.as_dict and
    two tests to load species from nasa polynomials in Arkane.
    
    squash! Add tests to load species from NASA polynomials
    goldmanm committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    18a916f View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1630 from ReactionMechanismGenerator/bugfix_nasa_…

    …as_dict
    
    Bugfix nasa as dict
    amarkpayne authored Jun 25, 2019
    Configuration menu
    Copy the full SHA
    4fab586 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2019

  1. Configuration menu
    Copy the full SHA
    a0d6dcf View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2019

  1. Merge pull request #1644 from ReactionMechanismGenerator/add_minicond…

    …a_dependencies
    
    Fix Travis builds by adding in missing miniconda dependencies
    alongd authored Jun 28, 2019
    Configuration menu
    Copy the full SHA
    227232b View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2019

  1. Configuration menu
    Copy the full SHA
    cc9eaf3 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2019

  1. Configuration menu
    Copy the full SHA
    abe7a09 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d32c30c View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1650 from ReactionMechanismGenerator/arkane_scan_doc

    Modified the Arkane ScanLog documentation
    amarkpayne authored Jul 12, 2019
    Configuration menu
    Copy the full SHA
    f6faa9f View commit details
    Browse the repository at this point in the history
  4. Refactor energy corrections in Arkane

    Make new encorr package which handles all energy corrections. Store all
    correction parameters in a dedicated data file. Handle bond additivity
    corrections in its own module, so that new types of bond additivity
    corrections can easily be implemented in the future.
    Colin Grambow committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    05a7916 View commit details
    Browse the repository at this point in the history
  5. Implement Melius-type bond additivity corrections in Arkane

    Instead of correcting the electronic energy using explicitly defined bond
    types, Anantharaman and Melius (JPCA, 2005) only use three fitted
    parameters per atom type to correct the energy. Implement the framework
    for this type of correction in the encorr package.
    Colin Grambow committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    d17fa57 View commit details
    Browse the repository at this point in the history
  6. Add bondCorrectionType option to Arkane

    bondCorrectionType can be set to 'p' to use conventional bond additivity
    corrections or to 'm' to use the newly implemented Melius-type corrections.
    Colin Grambow committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    2aadb6b View commit details
    Browse the repository at this point in the history
  7. Update Arkane documentation to reflect Melius-type bond additivity co…

    …rrections
    Colin Grambow committed Jul 12, 2019
    Configuration menu
    Copy the full SHA
    cdca610 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #1605 from ReactionMechanismGenerator/new_bacs

    Refactor energy corrections in Arkane and implement new bond additivity correction type
    mliu49 authored Jul 12, 2019
    Configuration menu
    Copy the full SHA
    58c1a06 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2019

  1. Added frequency scaling factors to Arkane

    Calculated using Truhlar's method
    alongd committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    a572256 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5be49c2 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1653 from ReactionMechanismGenerator/freq_scale

    Added two frequency scaling factors to Arkane
    Colin Grambow authored Jul 16, 2019
    Configuration menu
    Copy the full SHA
    7c1f46c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    be4e03f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    01729f3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f762263 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2019

  1. Refactor code for making objects so that it works recursively

    Should work no matter how many objects or dictionaries or lists are nested in each other. Most objects that inherits from RMGObject should work by default without  having to overwrite the make_object method
    amarkpayne committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    9bb64dd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    50aebac View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3528359 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    13b1cb6 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2019

  1. Merge pull request #1643 from ReactionMechanismGenerator/recursive_as…

    …_dictionary
    
    Recursive as dictionary
    alongd authored Jul 18, 2019
    Configuration menu
    Copy the full SHA
    2a4bef9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c4c190e View commit details
    Browse the repository at this point in the history
  3. F needs to be in element list.

    Otherwise when trying to make a sample molecule
    with an F groupAtom, it fails (and crashes
    with a segfault)
    rwest committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    f681d9f View commit details
    Browse the repository at this point in the history
  4. Also consider I atoms when making sample molecules.

    This list should cover all elements used in atomTypes.
    rwest committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    6e8e4ac View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c2f9495 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2d8f2bd View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2019

  1. Merge pull request #1657 from ReactionMechanismGenerator/fix_arkane_e…

    …xamples
    
    Fix frequencyScaleFactor in Arkane examples
    alongd authored Jul 20, 2019
    Configuration menu
    Copy the full SHA
    95e8fcf View commit details
    Browse the repository at this point in the history
  2. Refactor reaction generation and processing for reactEdge phase

    Motivation:
    - processNewReactions requires a newSpecies argument which was not
    being properly identified after multiprocessing changes in #1459
    
    Background:
    - The newSpecies argument is retained from early RMG when reactions
    were generated right after adding a new species to the core.
    - Hence, newSpecies referred to the newly added core species which
    was used to generate the new reactions.
    - The overall model generation algorithm has since changed, so
    identifying newSpecies is not as straightforward.
    - The multiprocessing PR changed newSpecies to be any core species,
    missing the original purpose of identifying the species from which
    the reaction was generated.
    
    Changes:
    - Use the species tuples created during reaction generation to
    keep track of which species were used to generate the reaction
    - Update unit tests which are affected by the changes in return values
    from react and react_all
    mliu49 committed Jul 20, 2019
    Configuration menu
    Copy the full SHA
    4b4580d View commit details
    Browse the repository at this point in the history
  3. Update docstrings in rmgpy.rmg.react module

    Also rename the spc_tuples arg in the react method to spc_fam_tuples
    to reflect updated usage.
    mliu49 committed Jul 20, 2019
    2 Configuration menu
    Copy the full SHA
    075da23 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2092de6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6e61a9f View commit details
    Browse the repository at this point in the history
  6. Reorganize imports in rmgpy.rmg.model

    Sort alphabetically and also remove relative imports
    mliu49 committed Jul 20, 2019
    Configuration menu
    Copy the full SHA
    fe6d118 View commit details
    Browse the repository at this point in the history
  7. Revert "Update arkane/explorerTest.py."

    This reverts commit d59da68.
    
    Lesson to be learned: If a unit test fails, make sure you
    understand why before changing the correct answer...
    mliu49 committed Jul 20, 2019
    Configuration menu
    Copy the full SHA
    687ce85 View commit details
    Browse the repository at this point in the history
  8. Add test class for CoreEdgeReactionModel.enlarge

    With tests for pdep network generation
    mliu49 committed Jul 20, 2019
    Configuration menu
    Copy the full SHA
    f968be8 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2019

  1. Merge pull request #1658 from ReactionMechanismGenerator/pdep_fix

    Fix pressure dependent network generation in RMG jobs
    amarkpayne authored Jul 21, 2019
    Configuration menu
    Copy the full SHA
    68367e8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    82d4871 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    271b2e9 View commit details
    Browse the repository at this point in the history
  4. Tests: Added Arkane thermoTest

    For now only tests the element_count_from_conformer() method, should be
    expanded.
    alongd committed Jul 21, 2019
    Configuration menu
    Copy the full SHA
    2e52dd5 View commit details
    Browse the repository at this point in the history
  5. Renamed elementCounts as element_counts

    THe Species.props['element_counts'] is only used in Arkane. renamed
    elementCounts to element_counts to be consistent with prior changes
    alongd committed Jul 21, 2019
    Configuration menu
    Copy the full SHA
    af10c4f View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2019

  1. Merge pull request #1651 from ReactionMechanismGenerator/element_coun…

    …t_from_conf
    
    Element count from conformer
    goldmanm authored Jul 23, 2019
    Configuration menu
    Copy the full SHA
    492d3f6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    109d125 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c391fa2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b03f060 View commit details
    Browse the repository at this point in the history
  5. Pass rcond=None to numpy.linalg.lstsq to silence warning

    Silence numpy warnings and use new default behavior
    
    From numpy documentation:
    
    Changed in version 1.14.0: If not set, a FutureWarning is given.
    The previous default of -1 will use the machine precision as rcond
    parameter, the new default will use the machine precision times max(M, N).
    To silence the warning and use the new default, use rcond=None,
    to keep using the old behavior, use rcond=-1.
    mliu49 committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    c8120d6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d99d95f View commit details
    Browse the repository at this point in the history
  7. Merge pull request #1659 from ReactionMechanismGenerator/reverse_pdep…

    …_multi
    
    Support reversing PDepArrhenius objects containing MultiArrhenius rates
    amarkpayne authored Jul 23, 2019
    Configuration menu
    Copy the full SHA
    f0d7d9f View commit details
    Browse the repository at this point in the history
  8. Update version number to 2.4.1

    mliu49 committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    dfe3c01 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f790671 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    4537d77 View commit details
    Browse the repository at this point in the history
  11. Update PDF documentation

    mliu49 committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    62db25f View commit details
    Browse the repository at this point in the history