-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Travis builds by adding in missing miniconda dependencies #1644
Conversation
The changes look reasonable and good. Do we know what suddenly triggered this problem? |
At first I wondered if dde and textgenrnn updated their dependencies, but seeing as we own the conda builds for these I guess not. |
We have decided to merge this PR to fix the issue, but we want to note that we are not quite sure what changed to cause this issue. One possible explanation is that the latest version of miniconda uses conda version 4.7.5, while (at the time of this PR) the version of anaconda you can download uses conda version 4.6.11 . Perhaps something changed in the newest version of conda that causes conda to be unable to resolve the package dependencies? Otherwise we are not sure what is so special about these two dependencies that need to be added to our environment files. |
Theory confirmed!! This does appear to be an issue with conda 4.7.5 that conda 4.6.11 does not have. I did a clean install of anaconda, and then upgraded conda to 4.7.5 and got the exact same error message (whereas in 4.6.11 I did not). I'll see if we can report the issue somewhere. |
Codecov Report
@@ Coverage Diff @@
## master #1644 +/- ##
======================================
Coverage 41.8% 41.8%
======================================
Files 177 177
Lines 29455 29455
Branches 6059 6059
======================================
Hits 12314 12314
Misses 16271 16271
Partials 870 870 Continue to review full report at Codecov.
|
I left an issue on conda's Github, let's see what they say. (Issue 8844) |
Motivation or Problem
Lately, every Travis build has been failing during the stage where the conda environment is created, with the following error message:
Interestingly, the conda environment builds just fine from a clean install of anaconda on the current master branch. However, after looking at how we have setup our Travis builds, I saw that we use miniconda on Travis. It appears that miniconda needs the dependencies of pydot-ng and pygpu to be explicitly given.
Description of Changes
Added pydot-ng and pygpu to the conda environment files.
Testing
On a clean Ubuntu machine, I first tried creating a fresh anaconda install, and creating the conda environment did not cause any problems. After cleaning this anaconda install, I then followed the travis.yml file instructions as closely as I could and used miniconda. This replicated the error on Travis. Finally, I updated the environment files, and again tried to install the environment from miniconda. This seemed to solve the issue
Reviewer Note
We will see for certain in a few minutes, but I believe this commit will solve the current Travis issue. Whether this is the best way to solve the issue or whether adding pydot-ng or pygpu will cause issues is something I am not sure about currently.