Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis builds by adding in missing miniconda dependencies #1644

Merged
merged 1 commit into from
Jun 28, 2019

Conversation

amarkpayne
Copy link
Member

Motivation or Problem

Lately, every Travis build has been failing during the stage where the conda environment is created, with the following error message:

ResolvePackageNotFound: 
  - dde -> pydot-ng
  - dde -> theano=0.9.0 -> pygpu[version='>=0.6.5,<0.7']
  - textgenrnn -> theano=0.9.0 -> pygpu[version='>=0.6.5,<0.7']

Interestingly, the conda environment builds just fine from a clean install of anaconda on the current master branch. However, after looking at how we have setup our Travis builds, I saw that we use miniconda on Travis. It appears that miniconda needs the dependencies of pydot-ng and pygpu to be explicitly given.

Description of Changes

Added pydot-ng and pygpu to the conda environment files.

Testing

On a clean Ubuntu machine, I first tried creating a fresh anaconda install, and creating the conda environment did not cause any problems. After cleaning this anaconda install, I then followed the travis.yml file instructions as closely as I could and used miniconda. This replicated the error on Travis. Finally, I updated the environment files, and again tried to install the environment from miniconda. This seemed to solve the issue

Reviewer Note

We will see for certain in a few minutes, but I believe this commit will solve the current Travis issue. Whether this is the best way to solve the issue or whether adding pydot-ng or pygpu will cause issues is something I am not sure about currently.

@alongd
Copy link
Member

alongd commented Jun 28, 2019

The changes look reasonable and good. Do we know what suddenly triggered this problem?

@amarkpayne
Copy link
Member Author

amarkpayne commented Jun 28, 2019

At first I wondered if dde and textgenrnn updated their dependencies, but seeing as we own the conda builds for these I guess not.

@alongd
Copy link
Member

alongd commented Jun 28, 2019

Both are from the rmg conda channel, modified by @cgrambow 2 and 8 months ago. But perhaps a different dependency of theirs got updated?

@amarkpayne
Copy link
Member Author

We have decided to merge this PR to fix the issue, but we want to note that we are not quite sure what changed to cause this issue. One possible explanation is that the latest version of miniconda uses conda version 4.7.5, while (at the time of this PR) the version of anaconda you can download uses conda version 4.6.11 . Perhaps something changed in the newest version of conda that causes conda to be unable to resolve the package dependencies? Otherwise we are not sure what is so special about these two dependencies that need to be added to our environment files.

@amarkpayne
Copy link
Member Author

Theory confirmed!! This does appear to be an issue with conda 4.7.5 that conda 4.6.11 does not have. I did a clean install of anaconda, and then upgraded conda to 4.7.5 and got the exact same error message (whereas in 4.6.11 I did not). I'll see if we can report the issue somewhere.

@codecov
Copy link

codecov bot commented Jun 28, 2019

Codecov Report

Merging #1644 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1644   +/-   ##
======================================
  Coverage    41.8%   41.8%           
======================================
  Files         177     177           
  Lines       29455   29455           
  Branches     6059    6059           
======================================
  Hits        12314   12314           
  Misses      16271   16271           
  Partials      870     870

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fab586...a0d6dcf. Read the comment docs.

@amarkpayne
Copy link
Member Author

I left an issue on conda's Github, let's see what they say. (Issue 8844)

@alongd alongd merged commit 227232b into master Jun 28, 2019
@alongd alongd deleted the add_miniconda_dependencies branch June 28, 2019 19:53
@mliu49 mliu49 mentioned this pull request Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Low Priority: Critical Should be addressed ASAP Status: Ready for Review PR is complete and ready to be reviewed Type: Error Type: Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants