Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xyz to smiles #141

Merged
merged 5 commits into from
Jun 30, 2019
Merged

xyz to smiles #141

merged 5 commits into from
Jun 30, 2019

Conversation

alongd
Copy link
Member

@alongd alongd commented Jun 28, 2019

Added an iPy notebook with an xyz to SMILES script

Also specify numpy and RDKit version

Also, don't load the RMG database if not necessary

@alongd
Copy link
Member Author

alongd commented Jun 28, 2019

Added pydot-ng to environment.yml, see ReactionMechanismGenerator/RMG-Py#1644

@codecov
Copy link

codecov bot commented Jun 29, 2019

Codecov Report

Merging #141 into master will decrease coverage by 1.82%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   42.63%   40.81%   -1.83%     
==========================================
  Files          27       27              
  Lines        6105     6106       +1     
  Branches     1578     1579       +1     
==========================================
- Hits         2603     2492     -111     
- Misses       3120     3245     +125     
+ Partials      382      369      -13
Impacted Files Coverage Δ
arc/processor.py 38.88% <0%> (-20.88%) ⬇️
arc/plotter.py 18.76% <0%> (-11.83%) ⬇️
arc/common.py 80.98% <0%> (-2.12%) ⬇️
arc/rmgdb.py 72.36% <0%> (-1.32%) ⬇️
arc/main.py 46.1% <0%> (-0.8%) ⬇️
arc/species/species.py 60.94% <0%> (-0.31%) ⬇️
arc/reaction.py 41.92% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce32cac...1b4b2c3. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 29, 2019

Codecov Report

Merging #141 into master will decrease coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   42.63%   42.63%   -0.01%     
==========================================
  Files          27       27              
  Lines        6105     6106       +1     
  Branches     1578     1579       +1     
==========================================
  Hits         2603     2603              
+ Misses       3120     3118       -2     
- Partials      382      385       +3
Impacted Files Coverage Δ
arc/processor.py 59.52% <33.33%> (-0.24%) ⬇️
arc/reaction.py 41.92% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce32cac...224e31f. Read the comment docs.

@alongd alongd merged commit 4a749fb into master Jun 30, 2019
@alongd alongd deleted the xyz_to_smiles branch June 30, 2019 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant