Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete simulation files after unit testing #1645

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Conversation

amarkpayne
Copy link
Member

Motivation or Problem

Whenever the unit test are run, the simulation logs in rmgpy.tools.simulateTest.py are created but never deleted (whereas everything else with this test is deleted).

Description of Changes

Add statements in rmgpy.tools.simulateTest.py to remove the log files after the tests have run.

Testing

Ran the unit tests and everything passed and the logs were deleted

@amarkpayne
Copy link
Member Author

This should pass all of the tests as soon as #1644 is merged

@codecov
Copy link

codecov bot commented Jun 28, 2019

Codecov Report

Merging #1645 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1645   +/-   ##
=======================================
  Coverage   41.82%   41.82%           
=======================================
  Files         177      177           
  Lines       29455    29455           
  Branches     6059     6059           
=======================================
  Hits        12319    12319           
  Misses      16267    16267           
  Partials      869      869

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 227232b...b1f47dd. Read the comment docs.

Copy link
Contributor

@yunsiechung yunsiechung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good.
It does successfully remove the log and backup log files after unit tests.

@amarkpayne amarkpayne merged commit cc9eaf3 into master Jul 2, 2019
@amarkpayne amarkpayne deleted the delete_sim_files branch July 2, 2019 17:40
@mliu49
Copy link
Contributor

mliu49 commented Jul 2, 2019

Thanks for catching this. The simulate logs were newly added in #1593.

@mliu49 mliu49 mentioned this pull request Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants