Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added two frequency scaling factors to Arkane #1653

Merged
merged 2 commits into from
Jul 16, 2019
Merged

Added two frequency scaling factors to Arkane #1653

merged 2 commits into from
Jul 16, 2019

Conversation

alongd
Copy link
Member

@alongd alongd commented Jul 16, 2019

Added frequency scaling factors for the wb97xd/def2tzvp and apfd/def2tzvpp levels of theory, calculated using Truhlar's method.
Should be straight forward to review.

@alongd alongd added the Arkane label Jul 16, 2019
@alongd alongd self-assigned this Jul 16, 2019
@alongd alongd requested a review from cgrambow July 16, 2019 03:09
Copy link

@cgrambow cgrambow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Travis failing with some Cairo issue. I'll restart it and see if it recovers.

@cgrambow
Copy link

Travis is still failing. Not sure why.

@mliu49
Copy link
Contributor

mliu49 commented Jul 16, 2019

Sorry, I was updating dependencies yesterday. The most recent cairocffi build apparently doesn't work on linux. I removed it so it should work now.

@cgrambow cgrambow merged commit 7c1f46c into master Jul 16, 2019
@cgrambow cgrambow deleted the freq_scale branch July 16, 2019 14:45
@mliu49 mliu49 mentioned this pull request Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants