-
Notifications
You must be signed in to change notification settings - Fork 230
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update docstrings in rmgpy.rmg.react module
Also rename the spc_tuples arg in the react method to spc_fam_tuples to reflect updated usage.
- Loading branch information
Showing
1 changed file
with
40 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
075da23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't quite believe the chances of this. I just spent (I won't admit how long) trying to debug something that called
react
(in the importer), and finally concluded that the docstrings were misleading, and I had just about figured out what it needed to be changed to, then came to check the history of the file so I could confirm when it had changed and open an issue,... then found this commit from 4 days ago. It is more than 4 days since I merged from master, and I had the old docstrings. 🤦♂Anyway, thanks for fixing them, Max!
075da23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a coincidence! We really should have updated the docstrings earlier when we changed behavior.
Note that this was motivated by another change in the return values for
react
, so you may need additional changes in the importer tool.