Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the Arkane ScanLog documentation #1650

Merged
merged 2 commits into from
Jul 12, 2019
Merged

Conversation

alongd
Copy link
Member

@alongd alongd commented Jul 12, 2019

Added a short description of Angle and its units when a ScanLog is read from a text file.
Also corrected a minor typo in common.py

Copy link
Member

@amarkpayne amarkpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll merge this once the tests have passed.

@codecov
Copy link

codecov bot commented Jul 12, 2019

Codecov Report

Merging #1650 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1650      +/-   ##
==========================================
+ Coverage    41.8%   41.82%   +0.01%     
==========================================
  Files         177      177              
  Lines       29455    29455              
  Branches     6059     6059              
==========================================
+ Hits        12314    12319       +5     
+ Misses      16271    16267       -4     
+ Partials      870      869       -1
Impacted Files Coverage Δ
rmgpy/data/kinetics/family.py 52.9% <0%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc9eaf3...d32c30c. Read the comment docs.

@amarkpayne amarkpayne merged commit f6faa9f into master Jul 12, 2019
@amarkpayne amarkpayne deleted the arkane_scan_doc branch July 12, 2019 16:09
@mliu49 mliu49 mentioned this pull request Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants