Output a debug string is Invalid @ parameter #1 #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
line 143 may be crash or buffer overflow. because the argument must is a pointer as char type that and have a valid buffer
| @@ -140,7 +140,7 @@ int rc_calibration_check(int mavlink_fd) { | |||
| /* sanity checks pass, enable channel */ | |||
| if (count) { | |||
| mavlink_log_critical(mavlink_fd, "ERROR: %d config error(s) for RC channel %d.", count, (i + 1)); | |||
| warnx(mavlink_fd, "ERROR: %d config error(s) for RC channel %d.", count, (i + 1)); | |||
| warnc(mavlink_fd, "ERROR: %d config error(s) for RC channel %d.", count, (i + 1)); | |||
There was a problem hiding this comment.
Good catch, thank you! The intent of this line was
warnx("ERROR: %d config error(s) for RC channel %d.", count, (i + 1));
Since the line already gets sent to the MAVLink app with the call above (mavlink_log_critical()). Would you mind updating the PR?
There was a problem hiding this comment.
PR mean is Pull Request ? How to update it?
I was wrong to think that "mavlink_fd" just a log identifies. ^ o ^
There was a problem hiding this comment.
Just do a new commit implementing the change and push to your branch (patch-2). The pull request will automatically update, and this diff will update, too.
There was a problem hiding this comment.
OK， Thx , I updated this request.
Btw, How to replace the CMSIS library in ARMv7-A system? Any DSP / Math library recommend?
Because I port PX4 firmware to samsung Exynos 4412 processor and running linux 3.x kernel now.
------------------ 原始邮件 ------------------
发件人: "Lorenz Meier";notifications@github.com;
发送时间: 2014年5月12日(星期一) 晚上10:48
收件人: "PX4/Firmware"Firmware@noreply.github.com;
抄送: "Assume"liio@qq.com;
主题: Re: [Firmware] Output a debug string is Invalid @ parameter #1 (#926)
In src/modules/systemlib/rc_check.c:
@@ -140,7 +140,7 @@ int rc_calibration_check(int mavlink_fd) { > /* sanity checks pass, enable channel */ > if (count) { > mavlink_log_critical(mavlink_fd, "ERROR: %d config error(s) for RC channel %d.", count, (i + 1)); > - warnx(mavlink_fd, "ERROR: %d config error(s) for RC channel %d.", count, (i + 1)); > + warnc(mavlink_fd, "ERROR: %d config error(s) for RC channel %d.", count, (i + 1));
Just do a new commit implementing the change and push to your branch (patch-2). The pull request will automatically update, and this diff will update, too.
—
Reply to this email directly or view it on GitHub.
LorenzMeier
added a commit
that referenced
this pull request
May 13, 2014
Output a debug string is Invalid @ parameter #1
PX4BuildBot
added a commit
that referenced
this pull request
Jul 3, 2019
NuttX: - https://github.com/PX4-NuttX/nuttx/tree/master - PX4/NuttX@7815c3a Changes from PX4/NuttX (PX4/NuttX@423371c) in current PX4/master (fecb32f) PX4/NuttX@423371c...7815c3a 7815c3a (HEAD, origin/master) Merged in masayuki2009/nuttx.nuttx/tiva_with_qemu (pull request #927) b6e7812 Merged in masayuki2009/nuttx.nuttx/fix_gs2200m (pull request #926) 1346f29 net/: Fix alignment and spacing problems found by tools/nxstyle. 7b554d6 Update README 79e79f0 Merged in alinjerpelea/nuttx (pull request #925) 574595d Still fixing new warnings found in build testing. 8774977 Fix warnings found in build testing. 077d164 /net/inet: Simplify design of change in last commit. de5a616 This commit implements a proper version of SO_LINGER. Not sufficiently tested on initial commit. ded1900 include/nuttx/net/net.h: Fix some long lines. Apps: - https://github.com/PX4/NuttX-apps/tree/master - PX4/NuttX-apps@ee8af2a Changes from PX4/NuttX-apps (PX4/NuttX-apps@7db2a35) in current PX4/master (fecb32f) PX4/NuttX-apps@7db2a35...ee8af2a ee8af2a (HEAD -> master, origin/master) Fix warnings found in build testing. 334b450 wireless/gs2200m/gs2200m_main.c: Fix a warning about an uninitialized return value found in build testing. 18a8032 examples/vl53l1x: Remove. The driver does not compile. 94ac7dc examples/vl53l1x: Add VL53L1X example demo. 27766d7 Merged in masayuki2009/nuttx.apps/fix_apps_industry (pull request #178) d2f3ad9 Merged in masayuki2009/nuttx.apps/wireless_gs2200m (pull request #177) 2c8e349 Merged in masayuki2009/nuttx.apps/add_system_gs2200m (pull request #176) 6561573 industry/abnt_codi, include/industry/abnt_code.h, examples.abntcodi: Adds support for ABNT CODI library. This is an energy meter protocol used in Brazil. bd14bf7 apps/netutils/json: Removed. Replaced with apps/netutils/cjson. 24e590b apps/nshlib/nsh_ddcmd.c: Seemingly nonsense change but somehow works around a compilation error using the ZDS-II toolchain. It was claiming that vtbl was undefined indd_outfopen().
PX4BuildBot
added a commit
that referenced
this pull request
Jul 3, 2019
NuttX: - https://github.com/PX4-NuttX/nuttx/tree/master - PX4/NuttX@55a4029 Changes from PX4/NuttX (PX4/NuttX@423371c) in current PX4/master (a2471fb) PX4/NuttX@423371c...55a4029 55a4029 (HEAD, origin/master) Merged in alinjerpelea/nuttx (pull request #928) 7815c3a Merged in masayuki2009/nuttx.nuttx/tiva_with_qemu (pull request #927) b6e7812 Merged in masayuki2009/nuttx.nuttx/fix_gs2200m (pull request #926) 1346f29 net/: Fix alignment and spacing problems found by tools/nxstyle. 7b554d6 Update README 79e79f0 Merged in alinjerpelea/nuttx (pull request #925) 574595d Still fixing new warnings found in build testing. 8774977 Fix warnings found in build testing. 077d164 /net/inet: Simplify design of change in last commit. de5a616 This commit implements a proper version of SO_LINGER. Not sufficiently tested on initial commit. Apps: - https://github.com/PX4/NuttX-apps/tree/master - PX4/NuttX-apps@b12b61d Changes from PX4/NuttX-apps (PX4/NuttX-apps@7db2a35) in current PX4/master (a2471fb) PX4/NuttX-apps@7db2a35...b12b61d b12b61d (HEAD -> master, origin/master) Merged in masayuki2009/nuttx.apps/fix_webserver (pull request #179) ee8af2a Fix warnings found in build testing. 334b450 wireless/gs2200m/gs2200m_main.c: Fix a warning about an uninitialized return value found in build testing. 18a8032 examples/vl53l1x: Remove. The driver does not compile. 94ac7dc examples/vl53l1x: Add VL53L1X example demo. 27766d7 Merged in masayuki2009/nuttx.apps/fix_apps_industry (pull request #178) d2f3ad9 Merged in masayuki2009/nuttx.apps/wireless_gs2200m (pull request #177) 2c8e349 Merged in masayuki2009/nuttx.apps/add_system_gs2200m (pull request #176) 6561573 industry/abnt_codi, include/industry/abnt_code.h, examples.abntcodi: Adds support for ABNT CODI library. This is an energy meter protocol used in Brazil. bd14bf7 apps/netutils/json: Removed. Replaced with apps/netutils/cjson.
PX4BuildBot
added a commit
that referenced
this pull request
Jul 4, 2019
NuttX: - https://github.com/PX4-NuttX/nuttx/tree/master - PX4/NuttX@48760b2 Changes from PX4/NuttX (PX4/NuttX@423371c) in current PX4/master (72a4494) PX4/NuttX@423371c...48760b2 48760b2 (HEAD, origin/master) Merged in masayuki2009/nuttx.nuttx/improve_gs2200m_performance (pull request #931) 55026f2 arch/arm/src/am335x: Add clock module registers definition. Switch to DMTIMER1 for systick. 03fe07c Merged in bkueng/nuttx/uart_invert_ioctl_continued (pull request #930) 093f98c arch/arm/src/imxrt/imxrt_usdhc.c: Implements SDIO and Multi-card support for i.MX RT. 1395938 arch/arm/src/stm32f7/stm32_serial.c: This adds the ability to invert and swap RX/TX on STM32F7 UARTs. I added the TIOCGINVERT as well to reserve the IOCTL number, but did not implement it. This is the same as for TIOCGSINGLEWIRE. 118d0f8 Trivial updates to last PR for minor issues reported by tools/nxstyle. 55a4029 Merged in alinjerpelea/nuttx (pull request #928) 7815c3a Merged in masayuki2009/nuttx.nuttx/tiva_with_qemu (pull request #927) b6e7812 Merged in masayuki2009/nuttx.nuttx/fix_gs2200m (pull request #926) 1346f29 net/: Fix alignment and spacing problems found by tools/nxstyle. Apps: - https://github.com/PX4/NuttX-apps/tree/master - PX4/NuttX-apps@c131733 Changes from PX4/NuttX-apps (PX4/NuttX-apps@7db2a35) in current PX4/master (72a4494) PX4/NuttX-apps@7db2a35...c131733 c131733 (HEAD -> master, origin/master) Merged in masayuki2009/nuttx.apps/mp3_on_webserver (pull request #180) b12b61d Merged in masayuki2009/nuttx.apps/fix_webserver (pull request #179) ee8af2a Fix warnings found in build testing. 334b450 wireless/gs2200m/gs2200m_main.c: Fix a warning about an uninitialized return value found in build testing. 18a8032 examples/vl53l1x: Remove. The driver does not compile. 94ac7dc examples/vl53l1x: Add VL53L1X example demo. 27766d7 Merged in masayuki2009/nuttx.apps/fix_apps_industry (pull request #178) d2f3ad9 Merged in masayuki2009/nuttx.apps/wireless_gs2200m (pull request #177) 2c8e349 Merged in masayuki2009/nuttx.apps/add_system_gs2200m (pull request #176) 6561573 industry/abnt_codi, include/industry/abnt_code.h, examples.abntcodi: Adds support for ABNT CODI library. This is an energy meter protocol used in Brazil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
line 143 may be crash or buffer overflow. because the argument must is a pointer as char type that and have a valid buffer