Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output a debug string is Invalid @ parameter #1 #926

Merged
merged 2 commits into from
May 13, 2014
Merged

Output a debug string is Invalid @ parameter #1 #926

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db2b85c
Output a debug string is Invalid @ parameter #1
ultrasystem May 12, 2014
ad51b4c
Update paramters for warnx()
ultrasystem May 12, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/modules/systemlib/rc_check.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ int rc_calibration_check(int mavlink_fd) {
/* sanity checks pass, enable channel */
if (count) {
mavlink_log_critical(mavlink_fd, "ERROR: %d config error(s) for RC channel %d.", count, (i + 1));
warnx(mavlink_fd, "ERROR: %d config error(s) for RC channel %d.", count, (i + 1));
warnc(mavlink_fd, "ERROR: %d config error(s) for RC channel %d.", count, (i + 1));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you! The intent of this line was

warnx("ERROR: %d config error(s) for RC channel %d.", count, (i + 1));

Since the line already gets sent to the MAVLink app with the call above (mavlink_log_critical()). Would you mind updating the PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR mean is Pull Request ? How to update it?
I was wrong to think that "mavlink_fd" just a log identifies. ^ o ^

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just do a new commit implementing the change and push to your branch (patch-2). The pull request will automatically update, and this diff will update, too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK， Thx , I updated this request.
Btw, How to replace the CMSIS library in ARMv7-A system? Any DSP / Math library recommend?
Because I port PX4 firmware to samsung Exynos 4412 processor and running linux 3.x kernel now.

------------------ 原始邮件 ------------------
发件人: "Lorenz Meier";notifications@github.com;
发送时间: 2014年5月12日(星期一) 晚上10:48
收件人: "PX4/Firmware"Firmware@noreply.github.com;
抄送: "Assume"liio@qq.com;
主题: Re: [Firmware] Output a debug string is Invalid @ parameter #1 (#926)

In src/modules/systemlib/rc_check.c:

@@ -140,7 +140,7 @@ int rc_calibration_check(int mavlink_fd) { > /* sanity checks pass, enable channel */ > if (count) { > mavlink_log_critical(mavlink_fd, "ERROR: %d config error(s) for RC channel %d.", count, (i + 1)); > - warnx(mavlink_fd, "ERROR: %d config error(s) for RC channel %d.", count, (i + 1)); > + warnc(mavlink_fd, "ERROR: %d config error(s) for RC channel %d.", count, (i + 1));
Just do a new commit implementing the change and push to your branch (patch-2). The pull request will automatically update, and this diff will update, too.

—
Reply to this email directly or view it on GitHub.

usleep(100000);
}

Expand Down