Mpm cleanups/v2 #9913
Closed
Mpm cleanups/v2 #9913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MPM_HS does not need a guard.
Bring implementation in line with Hyperscan, which only counts unique matches. Update test to reflect the new behavior.
Bring implementation in line with Hyperscan, which only counts unique matches. Update test to reflect the new behavior.
Fall back to default matcher. Ticket OISF#6586.
Avoid redundant pointer checks; instead check once.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9913 +/- ##
==========================================
- Coverage 82.45% 82.36% -0.10%
==========================================
Files 972 970 -2
Lines 273057 271663 -1394
==========================================
- Hits 225156 223751 -1405
- Misses 47901 47912 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
Closed
|
Information: QA ran without warnings. Pipeline 16774 |
lukashino
approved these changes
Dec 1, 2023
| @@ -1132,7 +1132,6 @@ static int CheckMatch(const SCACTileSearchCtx *ctx, PrefilterRuleStore *pmq, | |||
| * pattern is "Foo" and the string is "Foo bar foo", matches would be reported | |||
| * as 2, when it should really be 1, since "foo" is not a true match. | |||
| */ | |||
| matches++; | |||
There was a problem hiding this comment.
you've removed the increment here, did you move it elsewhere outside this file? To me it would seem like it doesn't increment currently or it is somehow connected with the changes in the prior commit
But I guess likely the "SCACSearch" counts that for you
There was a problem hiding this comment.
the real unique matches were already counted elsewhere, but I realize I should remove the comment
Closed
|
replaced by #9935 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove "ac-bs" as it's not performing well enough.
Various mpm cleanups.
Replaces #9908 with some more cleanup commits.
https://redmine.openinfosecfoundation.org/issues/6586