-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mpm cleanups/v2 #9913
Mpm cleanups/v2 #9913
Conversation
MPM_HS does not need a guard.
Bring implementation in line with Hyperscan, which only counts unique matches. Update test to reflect the new behavior.
Bring implementation in line with Hyperscan, which only counts unique matches. Update test to reflect the new behavior.
Fall back to default matcher. Ticket OISF#6586.
Avoid redundant pointer checks; instead check once.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9913 +/- ##
==========================================
- Coverage 82.45% 82.36% -0.10%
==========================================
Files 972 970 -2
Lines 273057 271663 -1394
==========================================
- Hits 225156 223751 -1405
- Misses 47901 47912 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
Information: QA ran without warnings. Pipeline 16774 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good
@@ -1132,7 +1132,6 @@ static int CheckMatch(const SCACTileSearchCtx *ctx, PrefilterRuleStore *pmq, | |||
* pattern is "Foo" and the string is "Foo bar foo", matches would be reported | |||
* as 2, when it should really be 1, since "foo" is not a true match. | |||
*/ | |||
matches++; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you've removed the increment here, did you move it elsewhere outside this file? To me it would seem like it doesn't increment currently or it is somehow connected with the changes in the prior commit
But I guess likely the "SCACSearch" counts that for you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the real unique matches were already counted elsewhere, but I realize I should remove the comment
replaced by #9935 |
Remove "ac-bs" as it's not performing well enough.
Various mpm cleanups.
Replaces #9908 with some more cleanup commits.
https://redmine.openinfosecfoundation.org/issues/6586