Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conf: avoid quadratic complexity #6586

Closed
wants to merge 1 commit into from

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4812

Describe changes:

  • avoid quadratic complexity when adding many sequence nodes

cc @jasonish

Ticket: 4812

When adding many sequence nodes
@catenacyber catenacyber requested a review from a team as a code owner November 8, 2021 13:20
@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #6586 (9614410) into master (a87c7e5) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6586      +/-   ##
==========================================
+ Coverage   77.04%   77.06%   +0.02%     
==========================================
  Files         613      613              
  Lines      186693   186215     -478     
==========================================
- Hits       143833   143509     -324     
+ Misses      42860    42706     -154     
Flag Coverage Δ
fuzzcorpus 52.94% <100.00%> (+0.02%) ⬆️
suricata-verify 52.09% <100.00%> (-0.01%) ⬇️
unittests 63.08% <75.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@jasonish jasonish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 4785

@victorjulien victorjulien mentioned this pull request Nov 22, 2021
@victorjulien
Copy link
Member

Merged in #6629, thanks!

victorjulien added a commit to victorjulien/suricata that referenced this pull request Nov 28, 2023
victorjulien added a commit to victorjulien/suricata that referenced this pull request Nov 28, 2023
victorjulien added a commit to victorjulien/suricata that referenced this pull request Nov 28, 2023
Fall back to default matcher.

Ticket OISF#6586.
victorjulien added a commit to victorjulien/suricata that referenced this pull request Dec 1, 2023
victorjulien added a commit to victorjulien/suricata that referenced this pull request Dec 1, 2023
Fall back to default matcher.

Ticket OISF#6586.
victorjulien added a commit to victorjulien/suricata that referenced this pull request Dec 1, 2023
victorjulien added a commit to victorjulien/suricata that referenced this pull request Dec 1, 2023
Fall back to default matcher.

Ticket OISF#6586.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants