-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conf: avoid quadratic complexity #6586
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 4812 When adding many sequence nodes
Codecov Report
@@ Coverage Diff @@
## master #6586 +/- ##
==========================================
+ Coverage 77.04% 77.06% +0.02%
==========================================
Files 613 613
Lines 186693 186215 -478
==========================================
- Hits 143833 143509 -324
+ Misses 42860 42706 -154
Flags with carried forward coverage won't be shown. Click here to find out more. |
jasonish
approved these changes
Nov 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Information: QA ran without warnings. Pipeline 4785 |
Merged
Merged in #6629, thanks! |
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Nov 28, 2023
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Nov 28, 2023
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Nov 28, 2023
Fall back to default matcher. Ticket OISF#6586.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Dec 1, 2023
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Dec 1, 2023
Fall back to default matcher. Ticket OISF#6586.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Dec 1, 2023
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Dec 1, 2023
Fall back to default matcher. Ticket OISF#6586.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4812
Describe changes:
cc @jasonish