-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mpm cleanups/v2 #9913
Closed
Closed
Mpm cleanups/v2 #9913
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
574c8b5
detect: minor cleanup
victorjulien d6f5a5a
mpm: remove ac-bs implementation
victorjulien 9d574e6
mpm/ac: return only unique match count
victorjulien 8419a22
mpm/ac-ks: return only unique match count
victorjulien 08c0fff
mpm: document Search callback return value
victorjulien 7618e8e
mpm/ac-bs: add warning if still used
victorjulien 3cab038
mpm: cleanup pattern free function
victorjulien 6907588
mpm: free sids in MpmFreePattern as well
victorjulien b94c359
util/prefilter: constify sids
victorjulien b092417
rust: add copyright header to common.rs
victorjulien File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you've removed the increment here, did you move it elsewhere outside this file? To me it would seem like it doesn't increment currently or it is somehow connected with the changes in the prior commit
But I guess likely the "SCACSearch" counts that for you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the real unique matches were already counted elsewhere, but I realize I should remove the comment