Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mpm cleanups/v2 #9913

Closed
wants to merge 10 commits into from
Closed

Mpm cleanups/v2 #9913

wants to merge 10 commits into from

Commits on Nov 28, 2023

  1. detect: minor cleanup 

    MPM_HS does not need a guard.
    @victorjulien
    victorjulien committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    574c8b5 View commit details
    Browse the repository at this point in the history

  2. mpm: remove ac-bs implementation 

    Ticket: OISF#6586.
    @victorjulien
    victorjulien committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    d6f5a5a View commit details
    Browse the repository at this point in the history

  3. mpm/ac: return only unique match count 

    Bring implementation in line with Hyperscan, which only counts unique matches.

Update test to reflect the new behavior.
    @victorjulien
    victorjulien committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    9d574e6 View commit details
    Browse the repository at this point in the history

  4. mpm/ac-ks: return only unique match count 

    Bring implementation in line with Hyperscan, which only counts unique matches.

Update test to reflect the new behavior.
    @victorjulien
    victorjulien committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    8419a22 View commit details
    Browse the repository at this point in the history

  5. mpm: document Search callback return value

    @victorjulien
    victorjulien committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    08c0fff View commit details
    Browse the repository at this point in the history

  6. mpm/ac-bs: add warning if still used 

    Fall back to default matcher.

Ticket OISF#6586.
    @victorjulien
    victorjulien committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    7618e8e View commit details
    Browse the repository at this point in the history

  7. mpm: cleanup pattern free function 

    Avoid redundant pointer checks; instead check once.
    @victorjulien
    victorjulien committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    3cab038 View commit details
    Browse the repository at this point in the history

  8. mpm: free sids in MpmFreePattern as well

    @victorjulien
    victorjulien committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    6907588 View commit details
    Browse the repository at this point in the history

  9. util/prefilter: constify sids

    @victorjulien
    victorjulien committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    b94c359 View commit details
    Browse the repository at this point in the history

  10. rust: add copyright header to common.rs

    @victorjulien
    victorjulien committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    b092417 View commit details
    Browse the repository at this point in the history