Mpm cleanups/v1 #9908
Closed
Mpm cleanups/v1 #9908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9908 +/- ##
==========================================
- Coverage 82.45% 82.35% -0.11%
==========================================
Files 972 970 -2
Lines 273057 271662 -1395
==========================================
- Hits 225156 223732 -1424
- Misses 47901 47930 +29
Flags with carried forward coverage won't be shown. Click here to find out more. |
MPM_HS does not need a guard.
Bring implementation in line with Hyperscan, which only counts unique matches. Update test to reflect the new behavior.
Bring implementation in line with Hyperscan, which only counts unique matches. Update test to reflect the new behavior.
victorjulien
force-pushed
the
mpm-cleanups/v1
branch
from
6e36396
to
08c0fff
Compare
Fall back to default matcher. Ticket OISF#6586.
Closed
|
Information: QA ran without warnings. Pipeline 16759 |
Closed
|
replaced by #9913 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mpm related cleanups.
https://redmine.openinfosecfoundation.org/issues/6586