Next/20210701/v7 #6242
Merged
Next/20210701/v7 #6242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the other fuzz targets, and do not build it if fuzzpcap is available but we did not want to build the fuzz targets
Before, if Suricata parsed a rule without a 'sid' option, instead of failing that rule, the rule was parsed and attributed a sid 0. Changes to: detect-parse: - add logic to filter out rules without sid; - change unittest which didn't have a sid, but used to pass. detect-sid: add unittest for rules without sid or with sid: 0
Codecov Report
@@ Coverage Diff @@
## master #6242 +/- ##
==========================================
+ Coverage 76.91% 76.94% +0.02%
==========================================
Files 611 611
Lines 186253 186146 -107
==========================================
- Hits 143250 143222 -28
+ Misses 43003 42924 -79
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced Jul 1, 2021
Closed
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6240 #6216 #6208 #6219 #6221 #6192 #6211