Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings with Rust nightly #6216

Closed
wants to merge 1 commit into from

Conversation

satta
Copy link
Contributor

@satta satta commented Jun 22, 2021

Describe changes:

  • Fix warnings with Rust nightly (rustc 1.55.0-nightly (406d4a9cc 2021-06-21)). These are simple changes relating to:
    • variables only used in debug output macros, which may be removed before compiling, making these variables unused, and
    • unused borrows in what should just be function calls.

@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #6216 (88b48ef) into master (b3c1f2a) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6216      +/-   ##
==========================================
+ Coverage   76.95%   76.96%   +0.01%     
==========================================
  Files         611      611              
  Lines      186232   186233       +1     
==========================================
+ Hits       143306   143328      +22     
+ Misses      42926    42905      -21     
Flag Coverage Δ
fuzzcorpus 52.92% <ø> (+0.01%) ⬆️
suricata-verify 51.13% <ø> (+0.05%) ⬆️
unittests 63.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Some part is duplicate with #6208

@satta
Copy link
Contributor Author

satta commented Jun 24, 2021

Should be done via #6222

@satta satta closed this Jun 24, 2021
@satta satta deleted the fix_warns_rust_nightly branch June 24, 2021 08:12
@satta satta restored the fix_warns_rust_nightly branch June 24, 2021 08:13
@satta
Copy link
Contributor Author

satta commented Jun 24, 2021

Or do we want to keep this open since #6222 was only merged into the 6.x line?

@catenacyber
Copy link
Contributor

I guess so

@catenacyber catenacyber reopened this Jun 24, 2021
@victorjulien victorjulien mentioned this pull request Jul 1, 2021
@victorjulien
Copy link
Member

Merged in #6242, thanks!

@satta satta deleted the fix_warns_rust_nightly branch July 1, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants