Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect/iprep: convert to FAIL/PASS API - v2 #6240

Closed
wants to merge 1 commit into from

Conversation

jufajardini
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4058

Describe changes:

  • detect-sid: convert unittests to FAIL/PASS API
  • cleanup tests (use DetectEngineAppendSig; change duplicated test - 5 and 6 the same; adjust some logic)
  • update copyright year

Previous PR:
#5571

@jufajardini jufajardini requested a review from a team as a code owner June 29, 2021 22:26
@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #6240 (2053be3) into master (b3c1f2a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6240      +/-   ##
==========================================
- Coverage   76.95%   76.94%   -0.01%     
==========================================
  Files         611      611              
  Lines      186232   186115     -117     
==========================================
- Hits       143306   143215      -91     
+ Misses      42926    42900      -26     
Flag Coverage Δ
fuzzcorpus 52.89% <ø> (-0.02%) ⬇️
suricata-verify 51.10% <ø> (+0.02%) ⬆️
unittests 63.08% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien mentioned this pull request Jul 1, 2021
@victorjulien
Copy link
Member

Merged in #6242, thanks!

@jufajardini jufajardini deleted the 4048/detect-iprep/v2 branch July 1, 2021 16:08
victorjulien added a commit to victorjulien/suricata that referenced this pull request Aug 1, 2023
Normalize the timestamps that are too far in the past to epoch.

Bug: OISF#6240.
victorjulien added a commit to victorjulien/suricata that referenced this pull request Aug 1, 2023
Normalize the timestamps that are too far in the past to epoch.

Bug: OISF#6240.
yatink pushed a commit to yatink/suricata that referenced this pull request Aug 19, 2023
Normalize the timestamps that are too far in the past to epoch.

Bug: OISF#6240.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants