Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect-engine: convert unittests to FAIL/PASS APIs v2 #6525

Conversation

ghostinthehive
Copy link
Contributor

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4024

Ticket: #4024
Prev-PR: #6523

Describe changes:

  • Update DetectEngineTest* unittests to use FAIL/PASS APIs
  • Structure the Tests to use a series of FAIL tests, and a final PASS at the end,
    if all FAIL tests aren't triggered.

@ghostinthehive
Copy link
Contributor Author

walking through previous merged FAIL/PASS APIs commits at #6242
there was a change of the source file' copyright year in PR #6240 .

Asking if I should update detect-engine.c copyright year since it's 2007-2020?

@jufajardini
Copy link
Contributor

walking through previous merged FAIL/PASS APIs commits at #6242 there was a change of the source file' copyright year in PR #6240 .

Asking if I should update detect-engine.c copyright year since it's 2007-2020?

Yes, please :) We'll usually update those as we work on them, so is indeed a good time for that.

@ghostinthehive
Copy link
Contributor Author

Opened a PR-v3 #6532

@ghostinthehive ghostinthehive deleted the fail/pass_4024_detect-engine-v2 branch November 1, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants