detect-engine: convert unittests to FAIL/PASS APIs v1 #6523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlucovsky
reviewed
Oct 27, 2021
| if (de_ctx->max_uniq_toclient_groups == 23 && | ||
| de_ctx->max_uniq_toserver_groups == 27) | ||
| result = 1; | ||
| PASS_IF(de_ctx->max_uniq_toclient_groups == 23 && |
There was a problem hiding this comment.
Suggest using FAIL_IF(!expression) instead here and other places where the final result is not yet known.
This structures the test as a series of FAIL occurrences with a final PASS if none of the failures has triggered.
There was a problem hiding this comment.
Thanks for you review! makes more sense this way.
Ill Include the changes in a PR-V2
3 tasks
|
Opened PR-v2 #6525 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are signed before submitting your Pull Request -- thank you.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4024
Ticket: #4024
Describe changes:
DetectEngineTest*unittests to use FAIL/PASS APIs