Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modbus: do not claim to handle gaps #6211

Closed
wants to merge 1 commit into from
Closed

modbus: do not claim to handle gaps #6211

wants to merge 1 commit into from

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4533

Describe changes:

  • modbus parser does not handle gaps

cc @cccs-sadugas

@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #6211 (585fe02) into master (b3c1f2a) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6211   +/-   ##
=======================================
  Coverage   76.95%   76.95%           
=======================================
  Files         611      611           
  Lines      186232   186232           
=======================================
+ Hits       143306   143307    +1     
+ Misses      42926    42925    -1
Flag Coverage Δ
fuzzcorpus 52.91% <ø> (+<0.01%) ⬆️
suricata-verify 51.07% <ø> (-0.01%) ⬇️
unittests 63.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien mentioned this pull request Jul 1, 2021
Merged
@victorjulien
Copy link
Member

Merged in #6242, thanks!

catenacyber added a commit to catenacyber/suricata that referenced this pull request Jul 12, 2023
@catenacyber
http2: do not append data after closing file
86655c2 
Ticket: OISF#6211

Completes commit 02dece5

Once a http2 stream has end of stream flag, we close the file.
If we see new data frames with this stream id, the new_chunk
function should ignore them as the file was already closed.
victorjulien pushed a commit to victorjulien/suricata that referenced this pull request Jul 13, 2023
@catenacyber @victorjulien
http2: do not append data after closing file
60db5e9 
Ticket: OISF#6211

Completes commit 02dece5

Once a http2 stream has end of stream flag, we close the file.
If we see new data frames with this stream id, the new_chunk
function should ignore them as the file was already closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonish jasonish Awaiting requested review from jasonish jasonish is a code owner

@victorjulien victorjulien Awaiting requested review from victorjulien

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@catenacyber @victorjulien