Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge master #397

Merged
merged 493 commits into from
Apr 4, 2022
Merged

merge master #397

merged 493 commits into from
Apr 4, 2022

Conversation

Nic-Ma
Copy link
Owner

@Nic-Ma Nic-Ma commented Apr 4, 2022

Fixes # .

Description

A few sentences describing the changes proposed in this pull request.

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli and others added 30 commits December 9, 2021 13:37
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
* [DLMED] add dataset generator

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] add DatasetGenerator

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>

* [MONAI] python code formatting

Signed-off-by: monai-bot <monai.miccai2019@gmail.com>

* [DLMED] fix wrong test

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] simplify according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] remove return

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update rtol for CI

Signed-off-by: Nic Ma <nma@nvidia.com>

Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
* [DLMED] add missing docs

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] add missing components

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix test

Signed-off-by: Nic Ma <nma@nvidia.com>
* [DLMED] add channel-wise

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix typo

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] skip test if before 1.7

Signed-off-by: Nic Ma <nma@nvidia.com>

* [MONAI] python code formatting

Signed-off-by: monai-bot <monai.miccai2019@gmail.com>

Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
* [DLMED] add Iteration base class

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
* [DLMED] support string dtype

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix typo

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] enhance dtype in ToCupy

Signed-off-by: Nic Ma <nma@nvidia.com>
* [DLMED] add Iteration base class

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
* [DLMED] support string dtype

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix typo

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] enhance dtype in ToCupy

Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
* Update to not include number for the name of the first range

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>

* Update CuCIM and TorchVision wrappers to include name

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>

* Update nvtx range to append undelying class for wrapper tranforms

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>

* Add new test cases to cover changes

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>

* Update cucim and torchvision check

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
* [DLMED] add missing images

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix 3471

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix AsDiscrete

Signed-off-by: Nic Ma <nma@nvidia.com>
* make bending energy loss invariant to resolution

fixes #3485

Signed-off-by: Ebrahim Ebrahim <ebrahim.ebrahim@kitware.com>

* set BendingEnergyLoss default normalize to False

Maybe it's more important that the default behavior match usage of the
term "bending energy" elsewhere, rather than that it be the most
convenient behavior.

Signed-off-by: Ebrahim Ebrahim <ebrahim.ebrahim@kitware.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
* [DLMED] correct kwargs

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix grammar

Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
* [DLMED] add SavitzkyGolaySmoothd

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix typo

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
* Adding Torchscript utility functions

Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [MONAI] python code formatting

Signed-off-by: monai-bot <monai.miccai2019@gmail.com>

* Adding Torchscript utility functions

Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>

* Added test for extra files

Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update

Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>

* Update

Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update

Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>

* Update

Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>

* Updates

Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Updates

Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>

* Updates

Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
Co-authored-by: Nic Ma <nma@nvidia.com>
* [DLMED] change to utility transforms

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] enhance args

Signed-off-by: Nic Ma <nma@nvidia.com>
* adds missing item

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update the contributing guide

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update copyright headers

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
* util to check the licence info

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update flags

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update based on comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
… APIs (#3526)

* [DLMED] clarify old APIs

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>
Nic-Ma and others added 29 commits March 15, 2022 15:43
* [DLMED] enhance reader

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix docs

Signed-off-by: Nic Ma <nma@nvidia.com>
* fixes #3934

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* min_test update

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* cu115 tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
* use enum for dicece reduction

Signed-off-by: Yiheng Wang <vennw@nvidia.com>

* use look up option

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
* [DLMED] update to 21.10

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix typo in integration test config

Signed-off-by: Nic Ma <nma@nvidia.com>
* attention unet

Signed-off-by: Juan Pablo de la Cruz Gutiérrez <juampatronics@gmail.com>

* [MONAI] python code formatting

Signed-off-by: monai-bot <monai.miccai2019@gmail.com>

* fixed issues and added suggested improvements

Signed-off-by: Juan Pablo de la Cruz Gutierrez <juampatronics@gmail.com>

* fixed flake issues

* smaller tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
* [DLMED] add verify script

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix typo

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] add unit tests and doc

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix flake8

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] skip min tests

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] remove doc-string

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix typo

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update device names

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update doc-string examples

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] enhance error message

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] cpu:0 to cpu

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] adjust "dataset_dir"

Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
* fixes #3942

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* adds import statement

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* more tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update to resolve import statement

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update based on comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update based on comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
* Minor change to UNet to permit greater modifiability

Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>

* Type fix

Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>

* Reverting minor change

Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
* Check images dimensions and color channels

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
* fixes multiprocessing memory issue

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* Revert "Workaround OOM issue in classification 2D integration tests (#3949)"

This reverts commit 6ea9742.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fixes typo

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* [DLMED] support relative ids

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix typo in test

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] add description

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] optimize the logic

Signed-off-by: Nic Ma <nma@nvidia.com>
* fixes docstrings

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update based on comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
* [DLMED] add export script

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] add base unit test

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] add custom config item types and reference resolver

Signed-off-by: Nic Ma <nma@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [DLMED] enhance doc-string

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix typo

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] add logging

Signed-off-by: Nic Ma <nma@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [DLMED] remove customized configitem and resolver

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] remove assert ret

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update to ckpt_export

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update to .ts

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update min test

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] simplify args

Signed-off-by: Nic Ma <nma@nvidia.com>

* fixes integration tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* [DLMED] change to coverage

Signed-off-by: Nic Ma <nma@nvidia.com>

* update integration tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* [DLMED] fix blossom

Signed-off-by: Nic Ma <nma@nvidia.com>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Wenqi Li <831580+wyli@users.noreply.github.com>
Co-authored-by: Wenqi Li <wenqil@nvidia.com>
* [DLMED] add logging config

Signed-off-by: Nic Ma <nma@nvidia.com>

* [MONAI] python code formatting

Signed-off-by: monai-bot <monai.miccai2019@gmail.com>

* [DLMED] adjust config

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] add doc-string

Signed-off-by: Nic Ma <nma@nvidia.com>

Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
* update mmars, fixes #4003

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* adds typing

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update based on comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* workaround cucim

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
* fixes unit test

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* temp tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* adds docker version tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes #4016

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* local tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* remove mmar cache daily

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* remove cache

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* Revert "temp tests"

This reverts commit 238d883.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes typo

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
* update bundle doc

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update meta

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update intro

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update examples

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* adds yaml demo

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update schema

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update toc

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update doc page

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* $import

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* adds recommendations

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update config

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update based on comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* adds a link on CLI parsing

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
* fix pil via specifying cpuonly version

Signed-off-by: Yiheng Wang <vennw@nvidia.com>

* add push branch to check

Signed-off-by: Yiheng Wang <vennw@nvidia.com>

* remove extra line

Signed-off-by: Yiheng Wang <vennw@nvidia.com>

* remove push branch for upstream

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
* Add support for level as input

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>

* Add unittests for levels

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>

* Update docstring

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>

* Add kwargs for WSIReader in all datasets

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>

* Update docstring

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@Nic-Ma Nic-Ma merged commit ec463d6 into Nic-Ma:main Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.