Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor change to UNet to permit greater modifiability #3975

Merged
merged 4 commits into from
Mar 22, 2022

Conversation

ericspod
Copy link
Member

Signed-off-by: Eric Kerfoot eric.kerfoot@kcl.ac.uk

Description

This change allows the definition of the skip connect in the UNet structure to be modified by subclasses. This appears to be a necessary change to allow other UNet variant to inherit from this class and not require major reworking of internal operations.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
@ericspod ericspod requested review from rijobro, wyli and Nic-Ma March 22, 2022 11:42
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
@ericspod ericspod enabled auto-merge (squash) March 22, 2022 13:07
@wyli
Copy link
Contributor

wyli commented Mar 22, 2022

/build

@wyli wyli disabled auto-merge March 22, 2022 15:19
@wyli
Copy link
Contributor

wyli commented Mar 22, 2022

it still breaks one existing test: https://github.com/Project-MONAI/MONAI/runs/5643823770?check_suite_focus=true#step:7:22302

class TestNetworkConsistency(unittest.TestCase):

Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
@wyli
Copy link
Contributor

wyli commented Mar 22, 2022

/build

1 similar comment
@wyli
Copy link
Contributor

wyli commented Mar 22, 2022

/build

@wyli wyli enabled auto-merge (squash) March 22, 2022 16:44
@wyli wyli merged commit 40855f9 into Project-MONAI:dev Mar 22, 2022
@ericspod ericspod deleted the unet_tweak branch January 25, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants