Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3934 smaller integration tests for monai.bundle to avoid OOM #3941

Merged
merged 4 commits into from
Mar 15, 2022
Merged

3934 smaller integration tests for monai.bundle to avoid OOM #3941

merged 4 commits into from
Mar 15, 2022

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Mar 15, 2022 •
edited
Loading

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #3934

Description

  • move the test to tests/test_integration_bundle_run.py
  • change the parameters to smaller values

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested a review from Nic-Ma March 15, 2022 11:08
Nic-Ma
Nic-Ma approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your quick fix.

@wyli wyli force-pushed the 3934-bundle-run branch from a6f99a6 to 9af679d Compare March 15, 2022 12:13
@wyli
Copy link
Contributor Author

wyli commented Mar 15, 2022

/integration-test

@wyli
Copy link
Contributor Author

wyli commented Mar 15, 2022

/build

wyli added 4 commits March 15, 2022 19:24
@wyli
fixes Project-MONAI#3934
462dc1d 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
min_test update
8cd6cec 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
cu115 tests
ddf121e 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update tests
3296501 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the 3934-bundle-run branch from cea78e3 to 3296501 Compare March 15, 2022 19:24
@wyli
Copy link
Contributor Author

wyli commented Mar 15, 2022

/integration-test

@wyli
Copy link
Contributor Author

wyli commented Mar 15, 2022

/build

@wyli wyli marked this pull request as ready for review March 15, 2022 21:17
@wyli wyli enabled auto-merge (squash) March 15, 2022 21:17
@wyli wyli disabled auto-merge March 15, 2022 22:34
@wyli wyli enabled auto-merge (squash) March 15, 2022 22:34
@wyli wyli disabled auto-merge March 15, 2022 22:43
@wyli wyli merged commit 33f632a into Project-MONAI:dev Mar 15, 2022
@wyli wyli deleted the 3934-bundle-run branch April 27, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

monai.bundle run tests OOM
2 participants
@wyli @Nic-Ma