Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4043 Fix windows PIL issue #4044

Merged
merged 9 commits into from
Apr 1, 2022

Conversation

yiheng-wang-nv
Copy link
Contributor

Fixes #4043 .

Description

Via using cpuonly==2.0.0, this PR helps to fix the PIL issue (in conda workflow, see here: https://github.com/yiheng-wang-nv/MONAI/actions/runs/2075835896) which is produced by outdated torchvision.
In addition, in the latest test, the issue of #4011 is not existing.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv yiheng-wang-nv requested a review from wyli April 1, 2022 08:35
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for looking into this one

@wyli
Copy link
Contributor

wyli commented Apr 1, 2022

/build

@wyli wyli enabled auto-merge (squash) April 1, 2022 08:50
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the 4043-fix-windows-pil-issue branch from e3149eb to 4a05583 Compare April 1, 2022 09:22
@wyli
Copy link
Contributor

wyli commented Apr 1, 2022

/build

wyli and others added 3 commits April 1, 2022 10:52
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor

wyli commented Apr 1, 2022

/build

@wyli wyli merged commit 541d7ab into Project-MONAI:dev Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot import name 'PILLOW_VERSION' from 'PIL'
2 participants