Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3942 3966 adds _requires_ and import support #3945

Merged
merged 12 commits into from
Mar 21, 2022
Merged

3942 3966 adds _requires_ and import support #3945

merged 12 commits into from
Mar 21, 2022

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Mar 15, 2022 •
edited
Loading

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #3942
Fixes #3966

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
fixes Project-MONAI#3942
29243d2 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from Nic-Ma, ericspod and rijobro March 15, 2022 12:00
@wyli wyli marked this pull request as ready for review March 15, 2022 12:08
wyli and others added 4 commits March 15, 2022 23:16
@wyli
Merge branch 'dev' into 3942-adds-keyword
f0e74d4
@wyli
adds import statement
a1df0c4 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Merge branch 'dev' into 3942-adds-keyword
5ce92a4 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
more tests
8f1edac 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli changed the title 3942 adds _requires_ 3942 adds _requires_ and import support Mar 17, 2022
@wyli wyli changed the title 3942 adds _requires_ and import support 3942 3966 adds _requires_ and import support Mar 17, 2022
@wyli
Copy link
Contributor Author

wyli commented Mar 18, 2022

/build

Nic-Ma
Nic-Ma reviewed Mar 18, 2022
View reviewed changes
monai/bundle/config_item.py Outdated Show resolved Hide resolved
tests/testing_data/inference.json Outdated Show resolved Hide resolved
wyli added 2 commits March 18, 2022 12:31
@wyli
update to resolve import statement
3a763f9 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update based on comments
3305071 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested a review from Nic-Ma March 18, 2022 12:47
@wyli
update
9fc4d40 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Mar 18, 2022

/build

Nic-Ma
Nic-Ma reviewed Mar 20, 2022
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update.

monai/bundle/config_item.py Show resolved Hide resolved
monai/bundle/reference_resolver.py Show resolved Hide resolved
monai/bundle/config_item.py Show resolved Hide resolved
@wyli
update based on comments
040157a 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested a review from Nic-Ma March 20, 2022 14:50
@wyli
Copy link
Contributor Author

wyli commented Mar 20, 2022 •
edited
Loading

/black
/integration-test

@wyli
Copy link
Contributor Author

wyli commented Mar 21, 2022

/build

@wyli wyli enabled auto-merge (squash) March 21, 2022 10:43
@wyli
fixes unit tests
b3ce611 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Mar 21, 2022

/build

@wyli wyli merged commit ec19406 into Project-MONAI:dev Mar 21, 2022
@wyli wyli deleted the 3942-adds-keyword branch April 27, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@rijobro rijobro Awaiting requested review from rijobro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support of 'import' statement in bundle config adds a _requires_ key for ConfigComponent
2 participants
@wyli @Nic-Ma