This repository has been archived by the owner on Jun 7, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 64
Create dapp deposit and withdraw transactions #196
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement bip39 account generation - Closes #133 Some changes are still due to be made: - Add Bitcore Mnemonic license to the functions taken from their repository - Remove generateAccount from API method - Maybe add wordlist from other languages (after discussing benefit / size of the files ratio)
Broadcast signed transaction function - Fixes #124
Hide private methods - Closes #77
Refactor mnemonic.js usage, update licensing and add tests - Closes #140
…eers-and-options-to-configuration-file
Add yuidoc annotations for timeOffset - Closes #197
6300a8f
to
8bd26ba
Compare
Isabello
suggested changes
Jul 18, 2017
lib/transactions/transfer.js
Outdated
* @param secret | ||
* @param secondSecret | ||
<<<<<<< HEAD | ||
* @param dappId |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge conflict please fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, thank you.
Git hook validation - Closes #187
8bd26ba
to
237620f
Compare
Closing in favour of #200 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #145