Refactor mnemonic.js usage, update licensing and add tests - Closes #140 #141

toschdev · 2017-06-27T12:30:50Z

Add bitpay license to the mnemonic.js and wordlist
Using "new Buffer()" method shall be avoided and replaced with Buffer.from or Buffer.alloc in mnemonic.js according to: https://nodejs.org/api/buffer.html#buffer_buffer_from_buffer_alloc_and_buffer_allocunsafe
Add and refine tests
Add coveralls command to package.json and coveralls to gitignore

Closes #140

coveralls · 2017-06-27T12:40:43Z

Coverage increased (+0.1%) to 99.368% when pulling 9875cea on 140-peer-review into f946fd1 on development.

Isabello

No complaints from me

karmacoma

Already merged, but here is my review. Some very minor points.

karmacoma · 2017-06-28T15:55:59Z

test/transactions/crypto/index.js

-		// TODO Find out if this is because of NodeJS probably adding them while routing.
+	describe('#useFirstEightBufferEntriesReversed, #toAddress convert.js', function () {
+
+		it('should use a Buffer, cut after first 8 entries and reverse them. Create numeric addresss from this', function () {


it('should use a Buffer, cut after first 8 entries and reverse them, then create numeric addresss from this', function () {

karmacoma · 2017-06-28T15:58:04Z

test/transactions/crypto/index.js

 		});
-		*/
+


Remove line

karmacoma · 2017-06-28T15:58:10Z

test/transactions/crypto/index.js

@@ -56,6 +55,7 @@ describe('crypto/index.js', function () {

 			(hashString).should.be.equal('a665a45920422f9d417e4867efdc4fb8a04a1f3fff1fa07e998e86f7f7a27ae3');
 		});
+


Remove line

karmacoma · 2017-06-28T16:06:41Z

lib/utils/mnemonic.js

+ *
+ * https://github.com/bitpay/bitcore-mnemonic/blob/master/LICENSE
+ *
+ * --------------------------------------------------


* -----------------------------------------------------------------------------

karmacoma · 2017-06-28T16:07:17Z

lib/utils/mnemonic.js

+ * https://github.com/bitpay/bitcore-mnemonic/blob/master/LICENSE
+ *
+ * --------------------------------------------------
+ *
 * Copyright © 2017 Lisk Foundation
 *
 * See the LICENSE file at the top-level directory of this distribution


* See the LICENSE file at the top-level directory of this distribution.

karmacoma · 2017-06-28T16:07:39Z

lib/utils/mnemonic.js

@@ -11,6 +21,7 @@
 *
 * Removal or modification of this copyright notice is prohibited.
 *
+ *


Remove line

karmacoma · 2017-06-28T16:08:22Z

lib/utils/mnemonic.js

@@ -149,7 +160,7 @@ function isValid(mnemonic) {
 	var cs = bin.length / 33;
 	var hashBits = bin.slice(-cs);
 	var nonhashBits = bin.slice(0, bin.length - cs);


var nonHashBits

toschdev added 6 commits June 27, 2017 12:35

Adds and refines tests, adds bitpay MIT license, adds coveralls command

094ecd6

Adds coveralls to gitignore

dc5e409

Adds coveralls to gitignore

8cc00de

Removes unneccessary test

d4cb4bc

Fixes linting errors

cb4b5d3

Updates browser version, adds one eslint skip

9875cea

Isabello changed the title ~~Peer review - Solves #140~~ Refactor mnemonic.js usage, update licensing and add tests - Solves #140 Jun 28, 2017

Isabello changed the title ~~Refactor mnemonic.js usage, update licensing and add tests - Solves #140~~ Refactor mnemonic.js usage, update licensing and add tests - Closes #140 Jun 28, 2017

Isabello self-requested a review June 28, 2017 14:20

Isabello assigned toschdev Jun 28, 2017

Isabello added ♻️ refactoring update labels Jun 28, 2017

Isabello approved these changes Jun 28, 2017

View reviewed changes

toschdev merged commit 75a656f into development Jun 28, 2017

toschdev deleted the 140-peer-review branch June 28, 2017 14:32

karmacoma reviewed Jun 28, 2017

View reviewed changes

karmacoma added ✅ ready and removed 🐛bug *easy 🌱 enhancement *medium ♻️ refactoring standards 📝 test update labels Aug 15, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor mnemonic.js usage, update licensing and add tests - Closes #140 #141

Refactor mnemonic.js usage, update licensing and add tests - Closes #140 #141

toschdev commented Jun 27, 2017 •

edited by Isabello

Loading

coveralls commented Jun 27, 2017

Isabello left a comment

karmacoma left a comment

karmacoma Jun 28, 2017

karmacoma Jun 28, 2017

karmacoma Jun 28, 2017

karmacoma Jun 28, 2017

karmacoma Jun 28, 2017

karmacoma Jun 28, 2017

karmacoma Jun 28, 2017

		@@ -56,6 +55,7 @@ describe('crypto/index.js', function () {

		(hashString).should.be.equal('a665a45920422f9d417e4867efdc4fb8a04a1f3fff1fa07e998e86f7f7a27ae3');
		});

Refactor mnemonic.js usage, update licensing and add tests - Closes #140 #141

Refactor mnemonic.js usage, update licensing and add tests - Closes #140 #141

Conversation

toschdev commented Jun 27, 2017 • edited by Isabello Loading

coveralls commented Jun 27, 2017

Isabello left a comment

Choose a reason for hiding this comment

karmacoma left a comment

Choose a reason for hiding this comment

karmacoma Jun 28, 2017

Choose a reason for hiding this comment

karmacoma Jun 28, 2017

Choose a reason for hiding this comment

karmacoma Jun 28, 2017

Choose a reason for hiding this comment

karmacoma Jun 28, 2017

Choose a reason for hiding this comment

karmacoma Jun 28, 2017

Choose a reason for hiding this comment

karmacoma Jun 28, 2017

Choose a reason for hiding this comment

karmacoma Jun 28, 2017

Choose a reason for hiding this comment

toschdev commented Jun 27, 2017 •

edited by Isabello

Loading