Skip to content
This repository has been archived by the owner on Jun 7, 2019. It is now read-only.

Peer Review PullRequests #140

Closed
toschdev opened this issue Jun 27, 2017 · 0 comments
Closed

Peer Review PullRequests #140

toschdev opened this issue Jun 27, 2017 · 0 comments

Comments

@toschdev
Copy link
Contributor

After merging Pull Requests, there have been some outstanding modifications

[] Add bitpay license to the mnemonic.js and wordlist
[] Using "new Buffer()" method shall be avoided and replaced with Buffer.from or Buffer.alloc in mnemonic.js according to: https://nodejs.org/api/buffer.html#buffer_buffer_from_buffer_alloc_and_buffer_allocunsafe
[] Add and refine tests
[] Add coveralls command to package.json and coveralls to gitignore

@toschdev toschdev self-assigned this Jun 27, 2017
toschdev pushed a commit that referenced this issue Jun 28, 2017
Refactor mnemonic.js usage, update licensing and add tests - Closes #140
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant