API should hide private methods

[slaweet]

There are several methods in the lisk-js API that aren't mentioned in the docs, look more like internal utility functions and shouldn't really be used by public, e.g. sendRequestPromise, getRandomPeer, banNode ...

If we expose these methods, people might use them in their projects and then we have to support them else we break other people's projects. On the other hand, if we make them private we can easily refactor and change their behaviour if necessary in the future.

There are several ways to emulate private methods in JavaScrtipt:
http://stackoverflow.com/questions/55611/javascript-private-methods

[alepop]

@slaweet can you type a full list of a private method?

[slaweet]

@alepop I'm not so familiar with lisk-js code to easily give a full list. @Tosch110 might be a more suitable person to do that.

[alepop]

@slaweet maybe all methods that are not in this list is private?

[slaweet]

@alepop makes sense. If not in documentation then they are private.