This repository has been archived by the owner on Jun 7, 2019. It is now read-only.
Broadcast signed transaction function - Fixes #124 #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toschdev
changed the title
MaciejBaj
reviewed
Jun 1, 2017
index.html
Outdated
| @@ -10,7 +10,7 @@ | |||
|
|
|||
| <script src="dist/lisk-js.js"></script> | |||
| <script> | |||
| "use strict"; | |||
|
|
|||
MaciejBaj
reviewed
Jun 1, 2017
test/api/liskApi.js
Outdated
| it('should be able to broadcast a finished and signed transaction', function (done) { | ||
|
|
||
| var LSKAPI = lisk.api({testnet: true}); | ||
| var amount = 0.001 * Math.pow(10, 8); |
MaciejBaj
reviewed
Jun 1, 2017
| <pre> | ||
| <code class="language-html" data-lang="html"> | ||
| var LSK = lisk.api({testnet: true}); | ||
|
|
There was a problem hiding this comment.
Yes, the html formating within < code > tags looks weird. But that is necessary for the display.
toschdev
dismissed
MaciejBaj’s stale review
All done but the html is necessary to keep like it is.
4miners
approved these changes
Jun 6, 2017
karmacoma
removed
*easy
🌱 enhancement
*medium
♻️ refactoring
standards
📝 test
update
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #124
Adds the broadcastSignedTransaction function to the API method.