Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better Workflow #4877

Open
tresf opened this issue Mar 6, 2019 · 61 comments
Open

Better Workflow #4877

tresf opened this issue Mar 6, 2019 · 61 comments
Labels
gui meta

Comments

@tresf
Copy link
Member

tresf commented Mar 6, 2019 •
edited by Rossmaxx
Loading

I'm creating a meta issue for better UI/UX workflow. This list should be updated frequently because it's the source of many of our new bug reports. If a new bug report arrives that seems workflow related AND won't be closed by a quick patch it can be marked as a duplicate and placed here.

Since workflow is so important to users -- something they can directly relate with -- this can also help serve as a futuremap if the developer team is to start milestoning certain enhancements (something we don't do a great job of currently)

Lastly, it can serve as a birds-eye-view (so to speak) of what our users really want. ❤️

💥 = Bug
🚀 = Good first issue for new developers

See also:

Tracks

Instruments

Mixer and Effects

Files and Folders

Misc/Overall
@LMMS LMMS deleted a comment from musikBear Mar 7, 2019
@tresf tresf mentioned this issue Mar 8, 2019
Closed
@qnebra
Copy link

qnebra commented Mar 9, 2019

I think this #4554 is very, very related to this topic. Especially for lmms users with external controllers like me.

Because for now lmms workflow with external controllers isn't as good as it should be.

@tresf
Copy link
Member Author

tresf commented Mar 9, 2019

@qnebra that sounds like a legitimate bug.

@tresf
Copy link
Member Author

tresf commented Mar 9, 2019 •
edited
Loading

@qnebra you sent me a PM on Discord and I want to be more clear. Your bug affects workflow (all bugs do), but it's not a "nice to have" feature, it's a legitimate bug and should be tracked as such.

Quoting the bug you've linked:

it works, only if you disconnect "volume" from "mod wheel".

I want to keep the legitimate bugs open in our tracker so that they're easier for developers to find, assign and work on. The features above are related to items -- in most cases -- completely missing from LMMS and are better left in a meta issue so that there's a bird's eye view of demand and related issue. I hope that helps!

@musikBear musikBear mentioned this issue Mar 9, 2019
Closed
This was referenced Mar 11, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
@zonkmachine
Copy link
Member

@craslaw sure!

@IanCaio
Copy link
Contributor

IanCaio commented Feb 14, 2021 •
edited
Loading

I've started work on #879. Can the original issue be reopened? I am taking the time to implement resizable rubberband selections where applicable instead of just fixing the cursor.

@craslaw Maybe you should wait until #5524 is merged, as it changes the logic and method that changes the cursor during TrackContentObjectViews mouse events. IMO it might make it even easier to fix this small issue with the resize cursor being used, as I think it's only a matter of adding a conditional to check if there are multiple selected TCOs.

@Spekular Spekular mentioned this issue Feb 20, 2021
Closed
@zonkmachine zonkmachine unpinned this issue Mar 7, 2021
@myutin myutin mentioned this issue May 21, 2021
Open
@Spekular Spekular mentioned this issue Oct 10, 2021
Closed
@Spekular Spekular mentioned this issue Feb 20, 2022
Closed
@Rossmaxx
Copy link
Contributor

@tresf can you update the list. i feel that a lot more of it has been fixed.

@Spekular
Copy link
Member

@tresf can you update the list. i feel that a lot more of it has been fixed.

Please don't do this unless you have specific issues in mind to be added or checked off.

@Rossmaxx
Copy link
Contributor

Rossmaxx commented May 15, 2022 •
edited
Loading

i mean just to update the check marks. it feels like he didn't update it for a long time and around 80% of the issues seem to be closed.

@Spekular
Copy link
Member

For our meta-issues the open/closed status of a child-issue does not determine whether or not the issue is resolved. Closing issues when we consolidate them lets us keep the open issue list a little more manageable. If you would go look at some of the recently consolidated issues you'd see this in action, they're marked as closed but not resolved.

This means the list is far from 80% complete and there are no updates to be made unless you can name a specific issue and the merged PR or commit that resolves said issue.

@tresf
Copy link
Member Author

tresf commented May 15, 2022 •
edited
Loading

@tresf can you update the list. i feel that a lot more of it has been fixed.

Sorry, if you look at the edit log, this issue is now maintained by Spekular and others. As instructed, any specifics that need updating, let us know. This bug tracker is huge and maintaining it is a lot of work, so the more specific the better. ♥️

@Spekular Spekular mentioned this issue May 23, 2022
Closed
@Rossmaxx
Copy link
Contributor

Rossmaxx commented Jun 3, 2022

Rename "FX Mixer" to "Mixer" Rename "FX-Mixer" to "Mixer" #3300

Hasn't this been done

@tresf

This comment was marked as outdated.

Sign in to view
@tresf
Copy link
Member Author

tresf commented Jun 3, 2022 •
edited
Loading

Rename "FX Mixer" to "Mixer" Rename "FX-Mixer" to "Mixer" #3300
Hasn't this been done

If this has all been done, the above issue (and the linked pull requests in that issue) don't seem to address it. If another PR/commit does close it, please link.

Found it, marking as done. #6239

sdasda7777 pushed a commit to sdasda7777/lmms that referenced this issue Jun 28, 2022
@zonkmachine @PhysSong
@IanCaio @Spekular @Veratil
Feature: Glue notes (LMMS#5721)
9c4acd7 
Tool to glue selected notes together. Selected notes that are
adjacent to each other or overlapping are transformed into one note
stretching over the combined notes on/off times.

Key command: <Shift> + G

Partially fixes: LMMS#746 which is part of LMMS#4877

Co-authored-by: Hyunjin Song <tteu.ingog@gmail.com>
Co-authored-by: IanCaio <iancaio_dev@hotmail.com>
Co-authored-by: Spekular <Spekularr@gmail.com>
Co-authored-by: Kevin Zander <veratil@gmail.com>
Co-authored-by: Oskar Wallgren <oskar.wallgren13@gmail.com>
@musikBear
Copy link

We have forgotten to add Blues-scale to the scale-selector.
This has now been asked for by a user.
We do have Blues-chord selection, so mark-all-corresponding is a work-around until we get Blues-scale into the Scale-selection.

@zonkmachine
Copy link
Member

zonkmachine commented Mar 16, 2023 •
edited
Loading

We have forgotten to add Blues-scale to the scale-selector.

The scale/chord selector is not god but those scales are there. Chord/Scale is selected from the number of notes. This means short scales like blues and pentatonic scales show up as chords and if you would add a very large chord in there it would show up as a scale. I believe this is mentioned elsewhere in the issue tracker.

@musikBear
Copy link

No not chord-selector. What he is missing is blues in this list:
image
Is that added in Latest Nightly?
As i said the work around is
image
It only takes a few mins to do, but imo we should add Blues to the scales

@zonkmachine
Copy link
Member

Chord selector. Top right, three scales visible.

screenshotx

@musikBear
Copy link

Chord selector. Top right, three scales visible.

screenshotx

Zonk Chords has nothing to do with this unless you want to use it as workaround for the missing SCALE

@zonkmachine
Copy link
Member

zonkmachine commented Mar 19, 2023 •
edited
Loading

Zonk Chords has nothing to do with this unless you want to use it as workaround for the missing SCALE

I'm not talking about a workaround but merely trying to point out the reason some chords/scales aren't showing up in the right selector.

Here is the code that choose between scale/chord depending on number of notes/size.

lmms/include/InstrumentFunctions.h

Lines 93 to 96 in 2baa23e

bool isScale() const
{
return size() > 6;
}

It's better to take this discussion to Discord if you're still not satisfied. Also, @Veratil knows more about this.

This was referenced May 3, 2023
Closed
Closed
@Rossmaxx
Copy link
Contributor

Show mixer channel on each instrument (#2563, 6411)
Show channel assignment on Song Editor #2563

completed via #6831

@michaelgregorius michaelgregorius mentioned this issue Sep 27, 2023
Closed
@Spekular
Copy link
Member

Spekular commented Oct 9, 2023

I've taken the liberty of adding #6930 and #6931 under the Song Editor and Piano Roll headings respectively. They may need to be scoped down if there are disagreements over how much state to save, but saving more than we do now is hopefully uncontroversial enough that these issues won't need to be removed from the list.

@Rossmaxx Rossmaxx removed this from the 1.3 milestone May 30, 2024
@Spekular Spekular mentioned this issue Jul 8, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gui meta
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests