Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicator on FX channels with no route to master #1224

Closed
unfa opened this issue Oct 18, 2014 · 19 comments
Closed

Indicator on FX channels with no route to master #1224

unfa opened this issue Oct 18, 2014 · 19 comments

Comments

@unfa
Copy link
Contributor

unfa commented Oct 18, 2014

no output

If you reroute channel A to another channel B (disabling the send to mixer) and you delete the "submix" channel B, the channel A is left with no output. One idea was to automatically re-route such channels to master again, another is to not do that, but show a warning in the mixer so the user knows that removing channel B made channel A unable to sound.

I consider this a related issue to this one: #1219

Both could be implemented with a combobox in the preferences window to choose what LMMS should do if "orphan channels" come into existance.

@Sti2nd
Copy link
Contributor

Sti2nd commented Oct 19, 2014

👍

@musikBear
Copy link

👍
...btw
Why are the label SEND -the channel actually recieves a signal 💋

@Sti2nd
Copy link
Contributor

Sti2nd commented Oct 19, 2014

@musikBear Because when you have a channel selected, you see what channels it sends to.

@unfa
Copy link
Contributor Author

unfa commented Oct 22, 2014

And you can select where you want each channel to send it's output.
Seems pretty straightforward to me.

@badosu
Copy link
Contributor

badosu commented Jan 23, 2015

If @unfa or someone else is able to create an artwork for this, with the same geometry of send/receive arrows, I should be able to implement it.

@diizy
Copy link
Contributor

diizy commented Jan 23, 2015

How exactly is "no output" determined?

@tresf
Copy link
Member

tresf commented Jan 23, 2015

Yeah "no output" is a bit vague. I would guess unfa means "No route to master".

-Tres

@badosu
Copy link
Contributor

badosu commented Jan 23, 2015

Yeah, this is what he describes on his original Feature Request, what would be the possible amibiguity? Or is it just the PR's title that annoys you?

@tresf tresf changed the title Show a warning for mixer channels that have no output Indicator on FX channels with no route to master Jan 23, 2015
@tresf
Copy link
Member

tresf commented Jan 23, 2015

Yeah, this is what he describes on his original Feature Request,

👍

If @unfa or someone else is able to create an artwork for this, with the same geometry of send/receive arrows, I should be able to implement it.

I have some reservations about this as the send arrows are covered by the vol knob in some instances where the "no route to master" would need to be displayed.

Should we instead leverage a different part of the UI? Perhaps make the LED Spinbox an alternate color with some tooltip text?

@badosu
Copy link
Contributor

badosu commented Jan 23, 2015

I have some reservations about this as the send arrows are covered by the vol knob in some instances where the "no route to master" would need to be displayed.

You're right, this is a problem, another possibility would be to change this FxLine widget's border to red-ish glow.

@Umcaruje
Copy link
Member

But channels that do not send to master are different, as they do not have the send indicator when you select master. I'm not sure what benefits a no output indicator would bring.
ohwowlook

@tresf
Copy link
Member

tresf commented Jan 23, 2015

@Umcaruje that's not a consistent indicator because it only shows when master is selected (or whatever it sends to).

-Tres

@badosu
Copy link
Contributor

badosu commented Jan 23, 2015

Yeah, from what I understand, this feature request is probably because on big projects it can get messy after you re-route mixers and add/delete a lot of instruments.

@unfa probably wants better tooling to keep the project sane.

@tresf
Copy link
Member

tresf commented Jan 23, 2015

FxLine widget's border to red-ish glow.

Let's prototype that and see how many people complain. :)

@diizy
Copy link
Contributor

diizy commented Jan 23, 2015

On 01/23/2015 04:01 PM, Tres Finocchiaro wrote:

Yeah "no output" is a bit vague. I would guess unfa means "No route to
master".

That's still a bit vague... what about sends with 0 gain? Remembering
also that send gains can be automated? What about mutes? And mute
automation?

Lots of small ambiguities there...

@diizy
Copy link
Contributor

diizy commented Jan 23, 2015

On 01/23/2015 05:55 PM, Amadeus Folego wrote:

another possibility would be to change this FxLine widget's border to
red-ish glow.

Ewww... maybe something less intrusive.

Performance concerns are also something to consider. We can't keep
checking the connections of all channels constantly, it's lots of wasted
CPU, so the check should be only performed when the connections are changed.

@badosu
Copy link
Contributor

badosu commented Jan 23, 2015

We can't keep checking the connections of all channels constantly, it's lots of wasted CPU, so the check should be only performed when the connections are changed.

That's the plan :-).

But this feature requests needs refinement until we have a proposal that adds quality to the software and solve the usability problem that is posed.

@tresf
Copy link
Member

tresf commented Jan 23, 2015

"No route to master".

That's still a bit vague...

In the context of channel routing, it is not vague at all.

@tresf
Copy link
Member

tresf commented Mar 11, 2019

If it does not, please send us a copy of your desktop installer

@tresf tresf closed this as completed Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants