Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User cannot see the FX Mixer connections at a glance: Some solutions #4181

Closed
raindropsfromsky opened this issue Feb 21, 2018 · 35 comments
Closed

Comments

@raindropsfromsky
Copy link

raindropsfromsky commented Feb 21, 2018

LMMS does not have an easy visualization that shows which instrument is connected with which FX channel; and also which channels are connected with other FX Channels.

I found a couple of implementations (see below)

Personally, I like the patch-panel matrix of Ardour

image

This implementation is not only clean, but it can convey a lot of information by color-coding the dots and the labels.

The second category is where the connection is shown with a line or curve.

image
IMHO this cannot convey the information like the patch matrix can. Probably the matrix is easier to code also!

image
This is from OpenOctave Midi.

At minimum, LMMS should display a list of all connections as extended tooltip.
(When the user hovers his mouse on a channel, show all connections in an extended tooltip.)

@musikBear
Copy link

At minimum, LMMS should display a list of all connections as extended tooltip.

Or the user should use Project-Notes and write down what he connect, and maby more important, why. Im not sure a visualisation is worth that much.

@Anonymouqs
Copy link
Contributor

Or the user should use Project-Notes and write down what he connect, and maby more important, why.

Some artists just feel, they like to try stuff out; sometimes, the user might want to see a "summary" instead of reading the actual book. Also, hand-documenting connections is beyond tedious, it is soul-destroying in a complicated project.

Finally, such visualization has clearly become a standard. If we want to set a standard(by going beyond), we must first meet it.

And every (good) standard has a reason, this is for the ease of the user and allows them to keep their music more organized. I feel Ardour's version would be more intuitive and allows ease of refactoring.

@Spekular
Copy link
Member

Spekular commented Feb 23, 2018 via email

@Anonymouqs
Copy link
Contributor

FWIW I'm more of a fan of the line connections (2 lists or FL style) than a
matrix display.

What if we support both types? Speaking of line-based views, I like OpenOctave's rendition a lot.

@tresf
Copy link
Member

tresf commented Feb 23, 2018

We wouldn't turn down any of the above proposals. The cable routing would fit within our current UI a bit better for the short-term. The matrix view may be better off as a full-mixer spectrum analyser so that each channel can be monitored without adding a visual plugin over and over; soloing; whatever we do today.

Cable-routing for reference to avoid link-rot:
image

@Anonymouqs
Copy link
Contributor

Another possible solution where the fx channel number is given in the Song-Editor. Maybe the user should be given different ways to visualize Channel Routing.
channelshow

@acidavid
Copy link

acidavid commented Mar 3, 2018

@Anonymouqs that would be a great idea, i woudn't have to open the plugin window everytime i need to reroute something!

@musikBear
Copy link

not only a great idea, just about 5. or 9. time this exact 'great idea' is proposed 🤣

@raindropsfromsky
Copy link
Author

@Anonymouqs, the FX Mixer already has the same information, and so this display would be redundant.
In fact, this channel number would occupy precious space in the track.

image

@raindropsfromsky
Copy link
Author

@tresf your screenshot itself shows the complete solution even if we ignore the interconnecting lines!

I have cropped your screenshot to remove the lines.
image

As shown above, the meaning is still absolutely clear!

This follows a simple "signal bus" concept, where-

  • The signal comes out of the channel that has a downward green arrow.
  • the signal enters any channel that has a volume control topped by a Circumflex symbol ˆ.

@raindropsfromsky
Copy link
Author

I have not used that sofftware, but I guess a black volume ring means the incoming signal is muted.
But the channel still assigned as incoming channel for that signal.

@raindropsfromsky
Copy link
Author

Compared to our SEND+arrow scheme, this scheme is far simpler and much more intuitive.

@musikBear
Copy link

musikBear commented Mar 4, 2018

https://user-images.githubusercontent.com/9047168/36935993-1fa0c47a-1f25-11e8-8ebf-769afc53b6c9.png
How can you see what comes from where and goes to witch - i only see a lot of arrows (and no indians:) in tresf img you can follow one 'cable' from and to, i cant in yours img (?)

@raindropsfromsky
Copy link
Author

raindropsfromsky commented Mar 4, 2018 via email

@acidavid
Copy link

acidavid commented Mar 4, 2018

@raindropsfromsky it might be redundant but i still think itd save lots of time from having to open each instrument everytime to assign a channel

@tresf
Copy link
Member

tresf commented Mar 5, 2018

FYI - The gear can assign a new or existing channel in 1.2.0. Use it all the time. :)

@WrillicR
Copy link
Member

WrillicR commented Mar 5, 2018

I think that we'd only need to add a visual and not completely remake the send system:
image
(that's just a mockup)

@tresf
Copy link
Member

tresf commented Mar 5, 2018

I think that we'd only need to add a visual and not completely remake the send system:

Agreed, although making the lines and the knobs near each other would be a nice touch. I think @raindropsfromsky has a valid point that the example #4181 (comment) is far superior for several reasons already pointed out as well as removed the english word "SEND" from our pixmaps. Help on this feature is greatly appreciated.

@raindropsfromsky
Copy link
Author

raindropsfromsky commented Mar 5, 2018

@tresf on second thought, @acidavid's idea seems to have a distinct advantage over "assign the channel using gear icon" scheme:

The assigned channel is visible on "per instrument" basis. In fact, the primary function of the FX MIxer is to control a group of instrument together and apply them various common effects, right? If so, the channel number in the FX Mixer actually could be assigned to multiple instruments at a time. (e.g. to "String" section of an orchestra). This many-to-one relationship is not being visualized currently. @acidavid's idea does that nicely.

In fact, let's assume that your strings are assigned to FX5. If you add a new string instrument to the Song Editor, and then try to assign it to a FX channel (using the gear), how will you assign it to FX5 unerringly? Now imagine that the other instruments are already displaying the FX channels (as suggested by @acidavid). Now it is easy to pick the correct FX channel.

When I tried to rebut his suggestion earlier, I overlooked this important factor.

But that suggestion fulfills a completely different need. It has no bearing on the alternatives we are considering in this thread. Actually it ought to be a separate ticket.

@acidavid
Copy link

acidavid commented Mar 5, 2018

@raindropsfromsky hey,thanks for the recognition, but thank @Anonymouqs it was his idea!

@acidavid
Copy link

acidavid commented Mar 5, 2018

i beleive in this project(and am also too broke to buy a powerfully licenced daw) but i believe in this project, seriously.didnt expect to get that far with a free daw

@raindropsfromsky
Copy link
Author

raindropsfromsky commented Mar 5, 2018

BTW @Mark-Agent003 your screenshot leaves some ambiguity as to how the channels are chained.

It could mean any of the following:

  • FX9 -> FX7 -> FX4, FX13, FX0
  • FX7+FX9 -> FX4, FX13, FX0

To eliminate the ambiguity, even the selected channel should show its arrow direction (and also its volume control).

@acidavid
Copy link

acidavid commented Mar 5, 2018

i beleive it is 9->7->4 and 13

@acidavid
Copy link

acidavid commented Mar 5, 2018

@raindropsfromsky

@raindropsfromsky
Copy link
Author

I have a doubt: Suppose I press the Solo button for FX13. It will mute all other FX channels, including FX7 and FX9. In that case will its incoming signal cut off?

Or does the mute button control only the OUTGOING connection to Master, and affects no other incoming connections?

@acidavid
Copy link

acidavid commented Mar 5, 2018

soloed, logically, id say it blocks the incoming(chained)signal but the signal that comes from the instruments directly assigned to its(13) bus shall still go to master unless it does not send to master and only to 7

@raindropsfromsky
Copy link
Author

@acidavid you have not mentioned output to Master, although the GUI shows it distinctly.
Thus we have a direct (dry) feed from FX9 to Master, and also wet feeds via FX7, FX10 and FX13.

@acidavid
Copy link

acidavid commented Mar 5, 2018

i think if you solo 13, you will only have instrument ->13->master and no 7, 9 and 13 which means that, as 9 (which is sending to 7 which is sending to 13) is muted, the signal from 9 and 7 will be muted and the only signal received is the one coming from instrument directly to 13

@acidavid
Copy link

acidavid commented Mar 5, 2018

but with this picture, we cant see which buses are connected to master and which are exclusively connected to another bus unless we click on master

@acidavid
Copy link

acidavid commented Mar 5, 2018

check out #4187 , this is an interesting solution @raindropsfromsky

@acidavid
Copy link

acidavid commented Mar 5, 2018

(nothing new, just aesthetic solution)

@WrillicR
Copy link
Member

WrillicR commented Mar 5, 2018

@raindropsfromsky the arrow icons at the top of each slot should indicate the direction, but as @tresf said, it would be clearer to have the arrows and knobs right next to the cables.

@raindropsfromsky
Copy link
Author

So, is it correct to sum up that-

  1. shift the volume knob+arrow to the bottom of the Channel.
  2. eliminate the SEND label.
  3. Show loops as @Mark-Agent003 shows.
  4. Show the volume knob and arrow even for the selected channel

@musikBear
Copy link

in respect to image #4181 (comment) -the connection overview would be much improved, if each of the lines had user-chosen colors

@tresf
Copy link
Member

tresf commented Mar 11, 2019

As part of a pruning effort, this enhancement request is archived into a dedicated "Better Workflow" checklist here #4877.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants