Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Channel Chaining to allow better Signal Flow #4195

Closed
Anonymouqs opened this issue Feb 26, 2018 · 5 comments
Closed

Allow Channel Chaining to allow better Signal Flow #4195

Anonymouqs opened this issue Feb 26, 2018 · 5 comments

Comments

@Anonymouqs
Copy link
Contributor

Can we have support for an effects channel to send to another channel instead of a master channel?
This would allow us to:

  • Apply effects in a more efficient manner. By allowing us to apply effects to groups of groups of signals.
  • Organize signals better.
  • For example, someone might want all of the bass to have a certain effect applied to them, but then individual groups of the bass might have certain effects applied to them.

For example, have channels 1,2,3 sent to channel 4, which would be sent to the Master Channel(by default)

I believe the implementation would be easy as the code is overall within the program:

  • Use the code from the built-in VSTs to choose a certain channel to send the signal to.
  • Applying the master channel code in able to allow a channel to receive another channel.
  • The only thing we really need to code is a circular dependency detector if it crashes the program. If it doesn't, in theory, those channels would be silent. But I do believe that just dependencies would crash LMMS.
  • By default, channels would send to master.
@Sawuare
Copy link
Member

Sawuare commented Feb 26, 2018

This is already implemented in LMMS 1.2.0-rc.5.
image

@tresf
Copy link
Member

tresf commented Feb 26, 2018

Yes, everything including circular detection are in 1.2.0. Closing.

d9d085d

@tresf tresf closed this as completed Feb 26, 2018
@Anonymouqs
Copy link
Contributor Author

Apologies, I found directions in the documentation. Can we add tooltips to the send channels? It's a bit confusing at first glance and would enhance user-friendliness.

@zonkmachine
Copy link
Member

Can we add tooltips to the send channels?

There is a PR for this against master. #4128
There is currently info (what's this text) available but no tooltip. Right click the send label and select 'Help' (bottom).

@tresf
Copy link
Member

tresf commented Feb 26, 2018

@Anonymouqs, in addition to the PR that @zonkmachine linked, @raindropsfromsky has proposed a more intuitive UI here: #4187, #4181.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants