Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make instrument change undoable #1262

Closed
grindhold opened this issue Nov 2, 2014 · 8 comments
Closed

make instrument change undoable #1262

grindhold opened this issue Nov 2, 2014 · 8 comments
Milestone

Comments

@grindhold
Copy link
Contributor

I often experiment around with how a track would sound if played with other instruments. However drag-n-dropping a new instrument or preset into a track is not undoable yet. Sometimes it's especially annoying when you place an instrument by accident into the track beneath or above the track you initially intended to drop the instrument on. In this case i often dont remember what instrument was in the other track to fix my mistake.
Being able to undo instrument changes would be very convenient.

@Sti2nd
Copy link
Contributor

Sti2nd commented Nov 3, 2014

Totally agrees on that, you can code that?

Note: I don't think we should file a new bug for everything which isn't undo-able. The only thing which is undoable is changed on notes in the Piano Roll

@grindhold
Copy link
Contributor Author

i could try coding that ;)

i don't quite get your sentence. did you mean "the only other thing which is undoable..."?
because i stated at least one other possibility in my original post, that you also confirmed.

I'll wait with coding new stuff until my current stuff gets reviewed and eventually merged. I have other projects too and i don't want to get too much issues parallel.

@tresf tresf added this to the 1.2.0 milestone Nov 3, 2014
@tresf
Copy link
Member

tresf commented Nov 3, 2014

@grindhold, we are so short on developers, you come as a breath of fresh air.

What @Sti2nd is asking is if you can make undo work everywhere in the software 😈 . Naturally this is a loaded question!

These types of questions are something you'll learn to expect from the more "enthusiastic" members of our community. :)

Thanks for showing interest in helping fix this software! Vesa and Toby generally review and approve the C++ pull requests and they generally do so in a timely manner. :)

@Sti2nd
Copy link
Contributor

Sti2nd commented Nov 3, 2014

Yes, I meant that "undoable". I only requested him to try to make undo/redo possible for instruments (that would include knobs), but of course I want you to make undo/redo everywhere 🍒

@grindhold
Copy link
Contributor Author

okay, of course i cannot promise to find and fix any undoable command in the program.
I am also not in favor of @Sti2nd's request not to open an issue for every occurence of the problem.
issues should be small and well-defined. a "fix every nonexistent undo"-issue would be an unclosable endless-issue.

@curlymorphic
Copy link
Contributor

#1284 It was decided to handle this in 2.0

@tresf tresf modified the milestones: 1.3.0, 1.2.0 Mar 9, 2015
@tresf
Copy link
Member

tresf commented Mar 9, 2015

Bumped (to 1.3 for now). Thanks! 👍

@SecondFlight
Copy link
Member

As part of a pruning effort, this enhancement request is archived into a dedicated "Better Workflow" checklist here #4877.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants