Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FX-Mixer: Drag'n'Drop Reordering #605

Closed
unfa opened this issue Apr 13, 2014 · 17 comments
Closed

FX-Mixer: Drag'n'Drop Reordering #605

unfa opened this issue Apr 13, 2014 · 17 comments

Comments

@unfa
Copy link
Contributor

unfa commented Apr 13, 2014

What?

The idea is to make FX-mixer strips reorderable just like tracks are - using mouse drag'n'drop technique.

Why?

Sometimes I'd like to change the order of my FX-Mixer channel strips.
I like to group instruments in the FX_mixer by their function and category:

  1. Drums
  2. Basses
  3. Pads
  4. Lead
  5. Special FX
    It happens, that I added a new Kickdrum that belongs to the first group, but I have to assign it to channel real-time testing branch #23 - I can't insert a new channel and offset all the rest to keep them linked and stuff.

Being able to reorder them just like instruments in the Song editor would be a great thing. Of course the numbers would change so all assigned instruments/sends should have to be updated. This could start mayhem if implemented poorly...

@diizy
Copy link
Contributor

diizy commented Apr 13, 2014

Yep, this has already been discussed I think... going to mark this for 1.1

@diizy diizy added this to the 1.1.0 milestone Apr 13, 2014
@diizy
Copy link
Contributor

diizy commented May 1, 2014

Partially fixed: fx channels can now be reordered via context menu, but drag-n-drop functionality is yet to be implemented. I'll do that later...

@diizy diizy self-assigned this May 1, 2014
@StakeoutPunch
Copy link

Rather than add drag and drop, would it be easier to add key shortcuts to move the selected track L/R?

@diizy
Copy link
Contributor

diizy commented May 1, 2014

On 05/02/2014 01:51 AM, StakeoutPunch wrote:

Rather than add drag and drop, would it be easier to add key shortcuts
to move the selected track L/R?

These are not mutually exclusive... keyboard shortcuts are a nice extra,
but they aren't very discoverable and don't fit all workflows, so they
shouldn't be the only/primary option.

@unfa
Copy link
Contributor Author

unfa commented May 8, 2014

On 1 May 2014 18:25, "Vesa V" notifications@github.com wrote:

Partially fixed: fx channels can now be reordered via context menu, but
drag-n-drop functionality is yet to be implemented. I'll do that later...

Great! That is already a big leap forward. Thank you :)


Reply to this email directly or view it on GitHub.

@Sti2nd
Copy link
Contributor

Sti2nd commented Jun 4, 2014

👍 With contextmenu you could have added the option to move 5 to right and left too, or write in how many channels.

@diizy
Copy link
Contributor

diizy commented Jun 6, 2014

This will probably have to be moved up to 1.2...

@badosu
Copy link
Contributor

badosu commented Jan 27, 2015

@unfa You can move mixers in a very fast way using <Alt-left/right> after selecting a channel.

I don't know if adding a grip to the mixers is desirable, but if it is: could you create a mockup for us to see how it would look like?

@Sti2nd
Copy link
Contributor

Sti2nd commented Jan 27, 2015

<Alt-left/right>

wat, when, why are no one documenting this. Or rather, we don't require devs to document what they make at all, and that is stupid?

@badosu
Copy link
Contributor

badosu commented Jan 27, 2015

Hi @Sti2nd, I was surprised to find this when I was tinkering with a mixer crash. But the require sutff you said, well, do you wanna help documenting? :-)

@Sti2nd
Copy link
Contributor

Sti2nd commented Jan 27, 2015

do you wanna help documenting?

Yes of course. FYI: I document everything I come over already, though not on one place... it is spread out over LMMS FB, the wiki and now the shortcut table.

@tresf
Copy link
Member

tresf commented Jan 28, 2015

could you create a mockup for us to see how it would look like?

Possible mockup (to re-use the realestate a bit):

image

@badosu
Copy link
Contributor

badosu commented Jan 28, 2015

Hmmm... is the top of the selected mixer used in any other way? Is this function overlapping any other that already exists?

I did not think we could do this in a nice way, but I liked your mockup, gonna try to implement this soon.

@tresf
Copy link
Member

tresf commented Jan 28, 2015

Is this function overlapping any other that already exists?

No that I'm aware of, but it would appear to require it to be selected to be moved which may be misleading.

@badosu
Copy link
Contributor

badosu commented Jan 28, 2015

@tresf Selecting it to move would be fine by me. It's better than having an extra grip hanging around all the time.

@tresf
Copy link
Member

tresf commented Jan 28, 2015

@badosu agreed and I'm not confident we can't clone the drag functionality to the title anyway. I don't really like the dedicated drag handles in software due to the amount of space they take up. I'm not sure how well this would work for Song Editor and BB Editor tracks, but whatever we decide we should be as consistent across interfaces as possible.

There's also an enhancement out there to do this drag handle up/down with the FX plugins themselves.

@tresf
Copy link
Member

tresf commented Mar 11, 2019

As part of a pruning effort, this enhancement request is archived into a dedicated "Better Workflow" checklist here #4877.

@tresf tresf closed this as completed Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants