Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-1.7: Backports for 1.7-RC1/1.7-beta4 #41499

Merged
merged 74 commits into from
Aug 3, 2021

Conversation

KristofferC
Copy link
Sponsor Member

@KristofferC KristofferC commented Jul 7, 2021

Backported PRs:

Non-merged PRs with backport label:

nalimilan and others added 4 commits July 7, 2021 10:27
Discovered while working on #40737. Currently, this throws an
unintuitive error:
```julia
julia> a, f()... = 1, 2, 3
ERROR: syntax: ssavalue with no def
Stacktrace:
 [1] top-level scope
   @ REPL[1]:1
```

Might as well fix this properly - Why not allow function definitions to
slurp a little from time to time? ;)

(cherry picked from commit 5c49a0d)
@BioTurboNick
Copy link
Contributor

BioTurboNick commented Jul 9, 2021

So this doesn't get lost: Consider marking #41201 for backport too. It's the last piece of the set of fixes to hvncat intended to go together.

Edit: #41200 I think should too once resolved, but it's not as critical since it's performance-related vs. correctness-related.

DilumAluthge and others added 19 commits July 19, 2021 11:48
* Transition the `coverage-linux64` pipeline to Buildkite

* Simplify, run inside of a sandbox

* Upload coverage reports to Codecov and Coveralls

* Add `COVERALLS_TOKEN`

Co-authored-by: Elliot Saba <staticfloat@gmail.com>
(cherry picked from commit 9d5f31e)
* Code coverage: fix the code coverage pipeline

* Run all tests

(cherry picked from commit 05e4138)
* Add "Check whitespace" buildkite job

* Add `key` values for later `wait` blocks

* Add "embedding tests" to buildkite configuration

* Eliminate unnecessary work in buildkite builds

Don't bother to precompile the Julia system image like we normally would
want to if we're just going to run things once.  Also use
`JULIA_NUM_CORES` instead of hard-coding `-j 6` into the buildsystem.

* Update embedding.yml

* Update whitespace.yml

(cherry picked from commit a2af845)
* Comment out signed pipeline test

This is confirmed working, so let's comment it out until it's actually used by a codesigning step or similar.

* Specifically notify llvm passes

(cherry picked from commit f2d7300)
* Add `/cache/repos` as a mapping into the CI sandbox

This should allow `git` to find its cached objects properly, which
should silence the warnings on CI, and also give us the proper git
version info within buildkite builds

* Break up `llvmpasses` output a bit

* Provide `/cache/repos` for `whitespace` as well

* Give a positive message if whitespace check passes

It's a little unnerving to have a silent command block in buildkite, so
let's output a success message if everything is on the up-and-up

(cherry picked from commit 460e981)
when building with USE_BINARYBUILDER=0

(cherry picked from commit 19ecf00)
* fix #41489: inference of `+(::Rational, Rational)`

* implement review comments

(cherry picked from commit cf4e1c4)
(cherry picked from commit 22c52a1)
* Add `less` to the `llvm-passes` rootfs image

Also, sort the entries of `packages` in alphabetical order.

* Update llvm-passes.jl

(cherry picked from commit 516af1b)
We had apparently misspelled this entitlement, not allowing `lldb` to attach to official macOS builds.

(cherry picked from commit ad6740b)
(cherry picked from commit d732903)
@KristofferC KristofferC requested a review from a team as a code owner July 19, 2021 09:49
@DilumAluthge DilumAluthge removed the request for review from a team July 19, 2021 09:51
@KristofferC
Copy link
Sponsor Member Author

@nanosoldier runtests(ALL, vs=":release-1.7")

@KristofferC
Copy link
Sponsor Member Author

@nanosoldier runtests(ALL, vs=":release-1.6")

@tkf
Copy link
Member

tkf commented Jul 19, 2021

This error

==13373==You are trying to dlopen a /cache/build/amdci5-0/julialang/julia-release-1-dot-7/tmp/test-asan/asan/usr/bin/../lib/libopenblas64_.so shared library with RTLD_DEEPBIND flag which is incompatible with sanitizer runtime (see https://github.com/google/sanitizers/issues/611 for details). If you want to run /cache/build/amdci5-0/julialang/julia-release-1-dot-7/tmp/test-asan/asan/usr/bin/../lib/libopenblas64_.so library under sanitizers please remove RTLD_DEEPBIND from dlopen flags.

--- https://buildkite.com/julialang/julia-release-1-dot-7/builds/23#ea03010c-a544-4bba-bd0a-c48293797b83/190-1104

indicates that libblastrampoline does not support LBT_USE_RTLD_DEEPBIND flag.

Backporting #41530 would require backporting #41522 which updated libblastrampoline.

Given the trouble we are experiencing with ASN on CI #41606, maybe it's better to not backport #41530, to avoid complicating the release process?

DilumAluthge and others added 13 commits July 26, 2021 11:04
…cumentation, and reorganize/rename/move a bunch of configuration files (#41698)

(cherry picked from commit e6e79f7)
…stead of `signature` (#41706)

* CI (Buildkite): for the signed pipeline test, use `signature_file` instead of `signature`

* Base64-decode the signature before writing it to the signature file

(cherry picked from commit f7f46af)
(cherry picked from commit 5386fa6)
(cherry picked from commit 71308eb)
(cherry picked from commit 8fa8530)
Makes the worker struct threadsafe as well as flushing the GC messages

(cherry picked from commit 0c073cc)
(cherry picked from commit 5af1cf0)
This seems to be a fairly arbitrary case for throwing exceptions, when
the user might often use this value in arithmetic afterwards, which is
not checked. It leads to awkward complexity in the API however, where it
may be unclear which function to reach for, with no particular
justification for why a particular usage is "safe". And it inhibits
optimization and performance due to the additional checks and error
cases (and is not even entirely type-stable).

(cherry picked from commit 3eefaf0)
Allows creating these ranges for any type of integer lengths.

Also need to be careful about using additive identity instead of
multiplicative, and be even more consistent now about types in a
few places.

Fixes #41517

(cherry picked from commit 4f77aba)
This is not a particularly meaningful combination (LLVM dislikes it).

(cherry picked from commit f7fdcac)
@KristofferC
Copy link
Sponsor Member Author

@nanosoldier runtests(ALL, vs=":release-1.7")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

@KristofferC
Copy link
Sponsor Member Author

@nanosoldier runtests(["AdaOPS", "AlphaStableDistributions", "BayesianBlocks", "BlobTracking", "CartesianGrids", "CorrelationFunctions", "Dispatcher", "DistributedJets", "DistributedOperations", "ECharts", "EFTfitter", "EcoSISTEM", "Enigma", "FixedPointNumbers", "GadgetIO", "GenericSchur", "GeometryBasics", "HalfIntegers", "ImageInpainting", "ImageTracking", "Images", "JuliaInterpreter", "LassoPlot", "LowLevelParticleFilters", "MCMCChain", "MatrixEquations", "MixedModelsPermutations", "MusicManipulations", "ParallelKMeans", "Revise", "SPHtoGrid", "Scalpels", "SimpleSDMLayers", "StaticRanges", "StatsPlots", "SymbolicRegression", "TensorBoardLogger", "TightBinding", "Transducers", "TreeParzen", "Unitful", "VideoIO", "Winston", "YAActL"], vs = ":release-1.7")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

maleadt and others added 6 commits August 2, 2021 10:33
(cherry picked from commit b50bf04)
…41722)

Also reverts "fixup to pull request #38405 (#41641)"

Seems to be causing hanging in CI testing.

This reverts commit 5af1cf0 and this
reverts commit 5a16805, reversing
changes made to 02807b2.

(cherry picked from commit 66f9b55)
…Range{<:Rational})` (#41479)

* Fix length(::AbstractUnitRange), faster length(::AbstractUnitRange{<:Rational})

(cherry picked from commit 1c951f7)
@KristofferC
Copy link
Sponsor Member Author

@nanosoldier runtests(["AdaOPS", "AlphaStableDistributions", "BayesianBlocks", "BlobTracking", "CartesianGrids", "CorrelationFunctions", "Dispatcher", "DistributedJets", "DistributedOperations", "ECharts", "EFTfitter", "EcoSISTEM", "Enigma", "FixedPointNumbers", "GadgetIO", "GenericSchur", "GeometryBasics", "HalfIntegers", "ImageInpainting", "ImageTracking", "Images", "JuliaInterpreter", "LassoPlot", "LowLevelParticleFilters", "MCMCChain", "MatrixEquations", "MixedModelsPermutations", "MusicManipulations", "ParallelKMeans", "Revise", "SPHtoGrid", "Scalpels", "SimpleSDMLayers", "StaticRanges", "StatsPlots", "SymbolicRegression", "TensorBoardLogger", "TightBinding", "Transducers", "TreeParzen", "Unitful", "VideoIO", "Winston", "YAActL"], vs = ":release-1.7")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

@KristofferC KristofferC merged commit 13d8a10 into release-1.7 Aug 3, 2021
@KristofferC KristofferC deleted the backports-release-1.7 branch August 3, 2021 07:28
@tkf
Copy link
Member

tkf commented Aug 22, 2021

@KristofferC @ararslan I just noticed beta4 was not released. I wonder if it is by oversight?

https://github.com/JuliaLang/julia/releases
https://julialang.org/downloads/

@ararslan
Copy link
Member

We're waiting on being able to code sign Windows binaries again, Elliot is looking into it

@tkf
Copy link
Member

tkf commented Aug 23, 2021

Ah, I see. Thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.