codegen: optimize setfield/arrayset with inline isa test #41587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
added
compiler:codegen
vtjnash
changed the title
|
@nanosoldier |
vtjnash
removed
the
needs nanosoldier run
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @christopher-dG |
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @christopher-dG |
82 tasks
|
@nanosoldier |
JeffBezanson
approved these changes
Jul 19, 2021
This is not a particularly meaningful combination (LLVM dislikes it).
vtjnash
force-pushed
the
jn/setfield-optim
branch
from
2bd9348
to
471e893
Compare
vtjnash
added
the
status:merge me
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @christopher-dG |
vtjnash
removed
the
status:merge me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't realize we weren't doing this, since it is quite trivial, and I was assuming it was done for some of the codegen tests for the new atomics. Needed to thus first disable a non-sensical atomic RMW operation and fix a return type.