Update libblastrampoline and mention how to use sanitizer with it #41522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't worry too much about that right now, I say go for it! I suggest copying the |
staticfloat
approved these changes
Jul 9, 2021
|
@tkf Feel free to ping me and Elliot if you run into trouble with the ASAN Buildkite job. |
82 tasks
tkf
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @staticfloat's JuliaLinearAlgebra/libblastrampoline#48, we can build
juliawith ASAN again (once the binary is shipped). This PR mentions the additional required settingLBT_USE_RTLD_DEEPBIND=0in the sanitizer documentation. In the second commit, I added a subsection mentioning concrete steps (based on @maleadt's setup).Also, I wonder if we can add ASAN build in the CI? I think I can give a shot at it but I don't know if it's worth pressuring the CI queue.