Initialize n_uninitialized for Symbol and SimpleVector #41496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Jul 7, 2021
KristofferC
pushed a commit
that referenced
this pull request
Jul 19, 2021
(cherry picked from commit 6240d35)
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I try to build
juliawith ASAN, I getThis assertion was tweaked in de6f62a#diff-e21748de252a5b69a0efe2c249a4c2cf4f844b9cd86503cc0c7e25fb654fc34cR353 in PR #41018. Bisection points to this commit.
Looking at the PR and how
->name->n_uninitializedis initialized forjl_datatype_type,jl_typename_typeandjl_methtable_type, it seems that we'd want to to addjl_symbol_type->name->n_uninitialized = 0andjl_simplevector_type->name->n_uninitialized = 0as well?