Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add embedding and whitespace jobs to buildkite #41321

Merged
merged 6 commits into from
Jul 7, 2021

Conversation

staticfloat
Copy link
Sponsor Member

Closes #41319

@staticfloat staticfloat requested a review from a team as a code owner June 22, 2021 22:19
@staticfloat staticfloat force-pushed the sf/embedding_and_whitespace branch 3 times, most recently from 3ee5ce3 to 1cfb0d8 Compare June 22, 2021 22:28
Don't bother to precompile the Julia system image like we normally would
want to if we're just going to run things once.  Also use
`JULIA_NUM_CORES` instead of hard-coding `-j 6` into the buildsystem.
@staticfloat staticfloat marked this pull request as draft June 22, 2021 22:52
@staticfloat
Copy link
Sponsor Member Author

staticfloat commented Jun 22, 2021

Alright, the embedding test is failing with undefined reference to 'jl_get_pgcstack'. I assume this is expected? @vtjnash

@DilumAluthge DilumAluthge removed the request for review from a team June 22, 2021 23:42
@DilumAluthge DilumAluthge added domain:building Build system, or building Julia or its dependencies domain:ci Continuous integration labels Jun 22, 2021
@staticfloat
Copy link
Sponsor Member Author

Alright, I'm merging this and we'll just live with a ❌ until someone who knows the embedding tests can fix it.

@staticfloat staticfloat marked this pull request as ready for review July 7, 2021 03:24
@staticfloat staticfloat merged commit a2af845 into master Jul 7, 2021
@staticfloat staticfloat deleted the sf/embedding_and_whitespace branch July 7, 2021 03:24
@DilumAluthge DilumAluthge added backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Jul 7, 2021
KristofferC pushed a commit that referenced this pull request Jul 12, 2021
* Add "Check whitespace" buildkite job

* Add `key` values for later `wait` blocks

* Add "embedding tests" to buildkite configuration

* Eliminate unnecessary work in buildkite builds

Don't bother to precompile the Julia system image like we normally would
want to if we're just going to run things once.  Also use
`JULIA_NUM_CORES` instead of hard-coding `-j 6` into the buildsystem.

* Update embedding.yml

* Update whitespace.yml

(cherry picked from commit a2af845)
@KristofferC KristofferC mentioned this pull request Jul 12, 2021
75 tasks
KristofferC pushed a commit that referenced this pull request Jul 19, 2021
* Add "Check whitespace" buildkite job

* Add `key` values for later `wait` blocks

* Add "embedding tests" to buildkite configuration

* Eliminate unnecessary work in buildkite builds

Don't bother to precompile the Julia system image like we normally would
want to if we're just going to run things once.  Also use
`JULIA_NUM_CORES` instead of hard-coding `-j 6` into the buildsystem.

* Update embedding.yml

* Update whitespace.yml

(cherry picked from commit a2af845)
KristofferC pushed a commit that referenced this pull request Jul 19, 2021
* Add "Check whitespace" buildkite job

* Add `key` values for later `wait` blocks

* Add "embedding tests" to buildkite configuration

* Eliminate unnecessary work in buildkite builds

Don't bother to precompile the Julia system image like we normally would
want to if we're just going to run things once.  Also use
`JULIA_NUM_CORES` instead of hard-coding `-j 6` into the buildsystem.

* Update embedding.yml

* Update whitespace.yml

(cherry picked from commit a2af845)
KristofferC pushed a commit that referenced this pull request Aug 31, 2021
* Add "Check whitespace" buildkite job

* Add `key` values for later `wait` blocks

* Add "embedding tests" to buildkite configuration

* Eliminate unnecessary work in buildkite builds

Don't bother to precompile the Julia system image like we normally would
want to if we're just going to run things once.  Also use
`JULIA_NUM_CORES` instead of hard-coding `-j 6` into the buildsystem.

* Update embedding.yml

* Update whitespace.yml

(cherry picked from commit a2af845)
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Sep 7, 2021
staticfloat added a commit that referenced this pull request Dec 23, 2022
* Add "Check whitespace" buildkite job

* Add `key` values for later `wait` blocks

* Add "embedding tests" to buildkite configuration

* Eliminate unnecessary work in buildkite builds

Don't bother to precompile the Julia system image like we normally would
want to if we're just going to run things once.  Also use
`JULIA_NUM_CORES` instead of hard-coding `-j 6` into the buildsystem.

* Update embedding.yml

* Update whitespace.yml

(cherry picked from commit a2af845)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:building Build system, or building Julia or its dependencies domain:ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move embedding tests to buildkite
3 participants