Package overhaul #61
Package overhaul #61
Conversation
christopher-dG
changed the title
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
===========================================
- Coverage 97.54% 63.29% -34.26%
===========================================
Files 16 15 -1
Lines 407 316 -91
===========================================
- Hits 397 200 -197
- Misses 10 116 +106
Continue to review full report at Codecov.
|
|
Note to self: use these for testing: |
christopher-dG
changed the title
|
@christopher-dG how can I help get this over the finish line? I have a new package I want to write |
|
You could plan my math lessons for me so that I have time to code π
. |
|
I looked over my work here this weekend and there's a whole lot that I want to change (and have been changing), but I can see myself getting this done in the next week or two, time permitting.
ha |
|
Title updated to reflect the somewhat significantly changed user APIs... π |
christopher-dG
force-pushed
the
cdg/plugins
branch
2 times, most recently
from
6f10735
to
743f1bc
Compare
christopher-dG
force-pushed
the
cdg/plugins
branch
from
284bbd5
to
445007b
Compare
|
Wew, this is very close to ready (after a really really long time). The initial comment up top has been updated with the current state of things. @iamed2 not sure how Invenia wants to go about reviewing this, I wouldn't really want to be tasked with looking at all this code myself... I'd be happy to walk someone through it over Slack or similar if that makes things easier. Just let me know what works best π |
|
Yeah that's fair. |
christopher-dG
force-pushed
the
cdg/plugins
branch
from
98aca71
to
5a89343
Compare
|
@christopher-dG Have you seen this: This can be a separate PR. Just wanted you to be aware of. |
|
@christopher-dG for pushing these ymls to Github's workflow some additional permissions are needed. I couldn't find them over the internet, but with Github desktop grants those automatically. |
|
I think here is the solution: https://stackoverflow.com/questions/57921401/push-to-origin-from-github-action |
|
Not sure if I'm interpreting this correctly, but wouldn't setting up a Git push be Documenter's responsibility? And even then, its pushes don't update workflow files. AFAIK no other GitHub Actions are trying to push. |
The problem is that without Google Desktop, I cannot push any .yml file to Github's workflow folder. So probably if the user generates a yml file using this template, they can't push it. |
|
Ok, after some digging, I'm guessing that you use a personal access token to authenticate with GitHub instead of your password? Because this issue only seems to affect access tokens, and I've just tried with both password and SSH and had no problems. |
christopher-dG
force-pushed
the
cdg/plugins
branch
2 times, most recently
from
1b0e6ab
to
d5a5eae
Compare
The docs deployment requires Documenter 0.24 but I'm assuming that PkgTemplates 0.7 won't be released until after Documenter 0.24.
This only came up when you generate more than one package in the same Julia session. The mutating `append!` function was adding stuff to the global variable that the coverage plugins were using for their gitignores. The new `vcat` is non-mutating.
christopher-dG
force-pushed
the
cdg/plugins
branch
from
d5a5eae
to
90253e5
Compare
|
π |
|
Congratulation π @christopher-dG |
Closes #72
Closes #87
Closes #95
Closes #92
Closes # 90Closes #80
Addresses #85 (does it supersede it? maybe)
Closes #103
Closes #104
Closes #96
Rewrites are fun π€·ββοΈ This got like, way out of hand.
It's finally ready for review!
In short, the new internal architecture makes plugins a lot more powerful and flexible than they used to be, so every part of package generation has been moved into various default plugins.
I've built the docs here so you don't need to build them yourself.
TODO
Some more interactive code, it's pretty raw right nowespecially interactive stuff