Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop using Pkg.generate #103

Closed
oxinabox opened this issue Nov 1, 2019 · 0 comments · Fixed by #61
Closed

stop using Pkg.generate #103

oxinabox opened this issue Nov 1, 2019 · 0 comments · Fixed by #61

Comments

@oxinabox
Copy link
Collaborator

oxinabox commented Nov 1, 2019

PkgTemplates.generate calls Pkg.generate
https://github.com/invenia/PkgTemplates.jl/blob/26a494410a5617af35acd8097ed3bcf303d71543/src/generate.jl#L18-L19

It doesn't do much at all. It wouild be like 5 lines to replace

Two reasons to stop doing it:

  1. Pkg developers often muse about just getting rid of Pkg.generate and telling people to use PkgTemplates
  2. It prevents us from expanding on it easily. E.g. I wanted to make a PR just now to change it so that the main module included a module docstring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant