Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the Pkg.generate function #1496

Closed
wants to merge 1 commit into from
Closed

Deprecate the Pkg.generate function #1496

wants to merge 1 commit into from

Conversation

DilumAluthge
Copy link
Member

Now that JuliaCI/PkgTemplates.jl#61 has been merged, PkgTemplates.jl no longer uses Pkg.generate.

Therefore, I think that we should officially deprecate Pkg.generate and direct users to PkgTemplates.jl. This will allow us to remove Pkg.generate in Julia 2.0.

This pull request adds the deprecation warning to Pkg.generate.

@codecov
Copy link

codecov bot commented Nov 10, 2019

Codecov Report

Merging #1496 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1496      +/-   ##
==========================================
+ Coverage   86.73%   86.73%   +<.01%     
==========================================
  Files          25       25              
  Lines        5451     5452       +1     
==========================================
+ Hits         4728     4729       +1     
  Misses        723      723
Impacted Files Coverage Δ
src/generate.jl 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c2dddd...769c68d. Read the comment docs.

@aminya
Copy link

aminya commented Nov 10, 2019

Agree. PkgTemplate has much more features

@DilumAluthge
Copy link
Member Author

Bump. Any opposition to deprecating the Pkg.generate function?

@rapus95
Copy link

rapus95 commented Feb 11, 2020

@DilumAluthge We'll also lose the REPL mode integration which is VERY convenient. Is there any chance that PkgTemplates.jl can hook into the REPL mode (including pkg"generate" macro)?

@DilumAluthge
Copy link
Member Author

I'm closing this as stale. We can revisit in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants